Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect plugin build stdout and pass to logger. #3763

Merged
merged 2 commits into from Feb 20, 2024

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Feb 20, 2024

When working a local fable plugin in Fable.Compiler I noticed that the build of the plugin was producing output in the process stdout. Which cannot happen in my vite-plugin setup.

This change redirects the output and prints it via the logger. Behaviour from Fable.Cli would be unaltered and Fable.Compiler would not write to the stdout.

Ready for review @MangelMaxime.
Could you also publish a new alpha for Fable.Compiler with this fix 馃槆?

@MangelMaxime MangelMaxime merged commit d37c262 into fable-compiler:main Feb 20, 2024
19 checks passed
@MangelMaxime
Copy link
Member

A new version has been released.

You PR aligned right on time with my planned release of today 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants