Problem with WebSocket constructor #377
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing websockets, essentially porting the code to Fable from https://github.com/SuaveIO/suave/blob/master/examples/WebSocket/index.html
I got this error in Chrome 52.0.2743.116:
"Error during WebSocket handshake: Sent non-empty 'Sec-WebSocket-Protocol' header but no response was received"
And the cause seems to be calling the websocket constructor as: new WebSocket(address, null);
If I manually changed it to new WebSocket(address) then it worked correctly.
This PR adds an overload to the constructor to prevent emitting null as the second parameter.