Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button #20

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Add a button #20

merged 1 commit into from
Feb 14, 2018

Conversation

forki
Copy link
Contributor

@forki forki commented Feb 14, 2018

@alfonsogarciacaro alfonsogarciacaro merged commit aa85a83 into master Feb 14, 2018
@forki forki deleted the button branch February 14, 2018 09:07
@alfonsogarciacaro
Copy link
Member

Done! BTW, you are also an owner of the nuget package, so you should be able to publish new versions if you need them fast. Just edit RELEASE_NOTES and run build.cmd GithubRelease (the script expects a NUGET_KEY env var).

@forki
Copy link
Contributor Author

forki commented Feb 14, 2018

got it. thanks

@forki
Copy link
Contributor Author

forki commented Feb 14, 2018

that nuget_key env variable is a dangerous thing - would love to pass it by command line arg instead

@forki
Copy link
Contributor Author

forki commented Feb 14, 2018

ok passing from cmd line works but I get PUT methodnotallowed from dotnet nuget push

Why are you not pushing with paket?

@alfonsogarciacaro
Copy link
Member

Hmm, that's weird. Paket push was giving problems (I think we already talked about that in a couple of other GH issues but don't remember where) and I changed it to dotnet push and it was working, so...

@forki
Copy link
Contributor Author

forki commented Feb 14, 2018

what problems? I seriously never had one.

@alfonsogarciacaro
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants