Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewPager has moved #47

Merged
merged 1 commit into from
Mar 13, 2019
Merged

ViewPager has moved #47

merged 1 commit into from
Mar 13, 2019

Conversation

forki
Copy link
Contributor

@forki forki commented Mar 12, 2019

@MangelMaxime
Copy link
Member

Do you want me to merge and release?

@forki
Copy link
Contributor Author

forki commented Mar 12, 2019

yes please, but the question is if we should separate it as well at some point

@MangelMaxime
Copy link
Member

What do you mean by separate?

Are @react-native-community/ and react-native a different packages?

@forki
Copy link
Contributor Author

forki commented Mar 12, 2019 via email

@MangelMaxime
Copy link
Member

Then indeed IMHO it's better to split the package.

We can remove completely the Helper or let it mark it as Obselete to help people migrate. If we mark it as Obselete we can let the old implementation in place so the transition is smoother or just use jsNative to force people to migrate.

@forki
Copy link
Contributor Author

forki commented Mar 12, 2019 via email

@forki forki merged commit 72f6138 into master Mar 13, 2019
@forki forki deleted the forki-patch-2 branch March 13, 2019 11:04
@forki
Copy link
Contributor Author

forki commented Mar 13, 2019

Ok I removed ViewPager and AsyncStorage from the main package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants