Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activeadmin 9132da6 form_buffer removed #3

Closed
ghost opened this issue Nov 10, 2014 · 6 comments
Closed

activeadmin 9132da6 form_buffer removed #3

ghost opened this issue Nov 10, 2014 · 6 comments

Comments

@ghost
Copy link

ghost commented Nov 10, 2014

In the current activeadmin master (9132da6) "form_buffer" in lib/active_admin/views/components/active_admin_form.rb has been removed. (raise "'form_buffers' has been removed from ActiveAdmin::FormBuilder, please read https://github.com/activeadmin/activeadmin/blob/master/docs/5-forms.md for details.") Therefore, activeadmin-globalize "f.translated_inputs" function does not work anymore.

@fabn
Copy link
Owner

fabn commented Nov 10, 2014

form_buffers was a private api and AFAIK the only way to add custom content in a form without using a full partial.

This is one of the reasons that lead me to open this issue activeadmin/activeadmin#3448 which was marked as dup of activeadmin/activeadmin#3213

I'll try to figure out how to fix this, meanwhile you should lock your AA version using git refs (I'm doing in this way in my app) to prevent this issue. And don't forget to vote for activeadmin/activeadmin#3213

Thanks for reporting this.

@ghost
Copy link
Author

ghost commented Nov 10, 2014

Thank you for your quick reply.

I'll have a look on activeadmin/activeadmin#3213 and will vote for it.
Can you please give me a hint on what last ref supported form_buffers?

@fabn
Copy link
Owner

fabn commented Nov 10, 2014

Here's the breaking change parent commit you should be able to lock you AA installation to this commit and solve the issue.

I've looked at the new behavior and it should be pretty easy to replace form_buffers with new dsl.

I'll keep you posted.

@fabn
Copy link
Owner

fabn commented Nov 10, 2014

I've pushed a new version in develop branch that should fix the issue. Let me know if it works for you.

However I won't release it on rubygems until AA itself is released (either as 1.0.0 or as .pre version)

@besi
Copy link

besi commented Mar 26, 2015

Please note that as of 12th of March there is a 1.0.0.pre1 release of Active Admin.

@fabn
Copy link
Owner

fabn commented Mar 26, 2015

Yes I saw that. I'll try to make this gem compatible with AA released version as soon as I can (I'll need that too).

wongy91 referenced this issue in coingecko/activeadmin-globalize Oct 10, 2018
* Bumping railties allowable version

* support JSONB types

* Add jsonb support explicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants