fixed macros when using an argument named like a PHP super globa

fabpot · Oct 11, 2014 · b5f0742 · b5f0742
1 parent d12f7af
commit b5f0742
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,6 @@
 * 1.16.2 (2014-XX-XX)
 
+ * fixed macros when using an argument named like a PHP super global (like GET or POST)
  * fixed date_modify when working with DateTimeImmutable
  * optimized for loops
  * fixed multi-byte characters handling in the split filter

diff --git a/lib/Twig/Node/Macro.php b/lib/Twig/Node/Macro.php
@@ -37,7 +37,7 @@ public function compile(Twig_Compiler $compiler)
         $pos = 0;
         foreach ($this->getNode('arguments') as $name => $default) {
             $compiler
-                ->raw('$_'.$name.' = ')
+                ->raw('$__'.$name.'__ = ')
                 ->subcompile($default)
             ;
 
@@ -64,7 +64,7 @@ public function compile(Twig_Compiler $compiler)
                 $compiler
                     ->write('')
                     ->string($name)
-                    ->raw(' => $_'.$name)
+                    ->raw(' => $__'.$name.'__')
                     ->raw(",\n")
                 ;
             }

diff --git a/test/Twig/Tests/Node/MacroTest.php b/test/Twig/Tests/Node/MacroTest.php
@@ -46,11 +46,11 @@ public function getTests()
         return array(
             array($node, <<<EOF
 // line 1
-public function getfoo(\$_foo = null, \$_bar = "Foo")
+public function getfoo(\$__foo__ = null, \$__bar__ = "Foo")
 {
     \$context = \$this->env->mergeGlobals(array(
-        "foo" => \$_foo,
-        "bar" => \$_bar,
+        "foo" => \$__foo__,
+        "bar" => \$__bar__,
     ));
 
     \$blocks = array();