This repository has been archived by the owner on May 29, 2024. It is now read-only.
Updated copy for #81 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My PR should look a little like this: |
edewit
suggested changes
Apr 24, 2017
There was a problem hiding this comment.
created a PR on your PR for the icons https://github.com/ALRubinger/launchpad-frontend/pull/1
| </p> | ||
| </div> | ||
| <h4></h4> | ||
| <div class="blank-slate-pf-main-action"> | ||
| <button class="btn btn-primary btn-lg btn-reg" (click)="launch()"> |
There was a problem hiding this comment.
I guess we don't want to start the wizard on this button, but got to "https://manage.openshift.com/openshiftio" so better would be to make it a link:
<a href="https://manage.openshift.com/openshiftio" class="btn btn-primary btn-lg btn-reg">There was a problem hiding this comment.
+1. This is also described in #83
|
Ready! |
|
|
edewit
approved these changes
Apr 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still TODO: add images of runtimes, Erik to review my frontend CSS and HTML crap
@edewit Mind a review and adding the images of the runtimes, centered, as indicated? It's OK to put 'em on white BGs; I know we already have transparent images so just use your best judgement.