Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Upgrade to go v11.1 for test-coverage CI #709

Merged
merged 3 commits into from
Nov 1, 2018

Conversation

alexeykazakov
Copy link
Contributor

Fixes #708

@alexeykazakov
Copy link
Contributor Author

Coverage build fails because gofmt was changed in v.1.11.
The coverage build uses go v1.11.1 but the main CI job uses go from centos image which is 1.9 (as far as I remember).
I think we have to skip gofmt check for the coverage build and keep it for the main build only.

@alien-ike
Copy link

alien-ike commented Nov 1, 2018

Ike Plugins (test-keeper)

Thank you @alexeykazakov for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #709 into master will increase coverage by 0.42%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   74.03%   74.45%   +0.42%     
==========================================
  Files          90       93       +3     
  Lines        9400     9462      +62     
==========================================
+ Hits         6959     7045      +86     
+ Misses       1927     1907      -20     
+ Partials      514      510       -4
Impacted Files Coverage Δ
login/profile.go 3.61% <0%> (ø) ⬆️
...ion/resourcetype/repository/resource_type_scope.go 47% <0%> (ø) ⬆️
account/repository/verification_code.go 59.75% <0%> (ø) ⬆️
login/link/keycloak_idp.go 0% <0%> (ø) ⬆️
...horization/role/repository/default_role_mapping.go 75% <0%> (ø) ⬆️
login/service.go 72.86% <100%> (ø) ⬆️
wit/service/wit_service.go 95% <100%> (ø) ⬆️
controller/token.go 75.47% <100%> (ø) ⬆️
controller/users.go 74.57% <100%> (ø) ⬆️
gormsupport/cleaner/db_clean.go 86.48% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b1ea5...9ae13bf. Read the comment docs.

@alexeykazakov
Copy link
Contributor Author

I'm switched all builds to go v.11.1 from the site in that PR and fixed formatting. Let's see if it's acceptable. If not then we can just skip formatting check when run tests with coverage.

Copy link
Member

@sbryzak sbryzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@sbryzak sbryzak merged commit 6c338ab into fabric8-services:master Nov 1, 2018
@alexeykazakov alexeykazakov deleted the go11 branch November 2, 2018 01:28
@sbose78
Copy link
Member

sbose78 commented Nov 2, 2018

I think we have to skip gofmt check for the coverage build and keep it for the main build only.

Agreed, coverage build shouldn't really have an business with gofmt checks.

I'm fine with this change - upgrading to go 11.1 sounds good to me. Good find @sbryzak !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants