-
Notifications
You must be signed in to change notification settings - Fork 26
Upgrade to go v11.1 for test-coverage CI #709
Conversation
Coverage build fails because gofmt was changed in v.1.11. |
Ike Plugins (test-keeper)Thank you @alexeykazakov for this contribution! It appears that no tests have been added or updated in this PR. Automated tests give us confidence in shipping reliable software. Please add some as part of this change. If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command Your plugin configuration is stored in the file. |
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 74.03% 74.45% +0.42%
==========================================
Files 90 93 +3
Lines 9400 9462 +62
==========================================
+ Hits 6959 7045 +86
+ Misses 1927 1907 -20
+ Partials 514 510 -4
Continue to review full report at Codecov.
|
I'm switched all builds to go v.11.1 from the site in that PR and fixed formatting. Let's see if it's acceptable. If not then we can just skip formatting check when run tests with coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
Agreed, coverage build shouldn't really have an business with gofmt checks. I'm fine with this change - upgrading to go 11.1 sounds good to me. Good find @sbryzak ! |
Fixes #708