Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image build skipped should not be pushed by default #1243

Open
ebaotech-oss opened this issue Jul 4, 2019 · 1 comment
Open

image build skipped should not be pushed by default #1243

ebaotech-oss opened this issue Jul 4, 2019 · 1 comment

Comments

@ebaotech-oss
Copy link

ebaotech-oss commented Jul 4, 2019

Hi,

Currently, when one of the image build is skipped (example below), push will still try to push all two images, is it possible for push to honor image.build.skip property?

<images>
    <image>
      <build>
        <name>image1</name>
        <skip>${maybe.skipped.1}</skip>
     </build>
   </image>
    <image>
      <build>
        <name>image2</name>
        <skip>${maybe.skipped.2}</skip> <!-- say this image build is skipped -->
     </build>
   </image>
<images>

Thanks

@rhuss
Copy link
Collaborator

rhuss commented Jul 23, 2019

I agree that there should be a possibility to skip the push for certain images. However, I would introduce a skipPush field (like skipTag), to deliberately specify that intent. This is mostly to not break backwards compatibility.

Unfortunately I don't have any spare time at the moment, so if you are interested in that feature, feel free to submit a pull request and I will help you to integrate it.

mattnelson added a commit to mattnelson/docker-maven-plugin that referenced this issue Aug 27, 2020
rhuss added a commit that referenced this issue Sep 1, 2020
* Add skipPush option to build image configuration (#1243)

* add changelog, add registry push test

Co-authored-by: Roland Huß <roland@ro14nd.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants