Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip FROM images which are referred to by a named alias #1478

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

davoustp
Copy link

@davoustp davoustp commented Jun 7, 2021

Fixes #1443
Image alias check was performed only for the FROM <alias1> AS <alias2> case and not for straight FROM <alias1> case.

Signed-off-by: Pascal Davoust pascal.davoust@enghouse.com

Signed-off-by: Pascal Davoust <pascal.davoust@enghouse.com>
@rohanKanojia
Copy link
Member

@davoustp : Could you please add a line to doc/changelog.md regarding this change? I think we can proceed with merge after that

@davoustp
Copy link
Author

davoustp commented Jun 8, 2021

Sure - did not see that (I supposed the changelog was automatically generated).
Process to do that from your point of view? Just commiting the change to my own repo enough? Or do you want me to squash the two commits together and force it upstream?

@rohanKanojia
Copy link
Member

Right now we're maintaining a changelog file: https://github.com/fabric8io/docker-maven-plugin/blob/master/doc/changelog.md

You would need to update it linking the bug you're fixing in 0.36-SNAPSHOT section.

Added changelog entry

Signed-off-by: Pascal Davoust <pascal.davoust@enghouse.com>
@davoustp
Copy link
Author

davoustp commented Jun 8, 2021

Done.

@rohanKanojia rohanKanojia merged commit 578e4eb into fabric8io:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Docker Multistage Build labeled stage is not detected
2 participants