You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 8, 2021. It is now read-only.
The code exposestrategy/route.go attempts to lookup the default domain via getAutoDefaultDomain if one isn't explicitly given and use that to create a hostname for the generated route on OpenShift. This requires cluster-wide admin privileges to do.
Instead of doing this, I propose we pass a blank hostname when creating the RouteSpec if no explicit domain is given and OpenShift will automatically generate one for us that includes the default domain. We can then retrieve the hostname from the generated route for use with addServiceAnnotation. The end result will be the same but this latter method does not require cluster-wide admin privileges.
The text was updated successfully, but these errors were encountered:
The code
exposestrategy/route.go
attempts to lookup the default domain viagetAutoDefaultDomain
if one isn't explicitly given and use that to create a hostname for the generated route on OpenShift. This requires cluster-wide admin privileges to do.Instead of doing this, I propose we pass a blank hostname when creating the RouteSpec if no explicit domain is given and OpenShift will automatically generate one for us that includes the default domain. We can then retrieve the hostname from the generated route for use with
addServiceAnnotation
. The end result will be the same but this latter method does not require cluster-wide admin privileges.The text was updated successfully, but these errors were encountered: