This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Fix NullPointerException in ConfigMapEnricher #1805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also seems to be a sideeffect of sundrio configuration change, A user
emailed about this problem.
To reproduce you can simply run fabric8:resource on one of these samples:
https://github.com/r0haaaan/eclipse-jkube-sample-with-resource-fragments
I checked again and I think this was the last place where annotations were being accessed unsafely. At other places it seems we're just appending newly created annotation depending upon enricher