Checking for openshift yaml recursively in the current directory

[rupalibehera]

checking recursively for openshift.yml and removed the hardcoded path for openshift.yaml

#13

cc: @rawlingsj

[rawlingsj]

where does FILES come from? I think that needs to be set?

[rupalibehera]

Yes my bad, I missed the import statement import static groovy.io.FileType.FILES. I kinda did a mock testing where I had imported it.

[rawlingsj]

The def openshiftYaml here means the rest of the function cant see it. You can define openshiftYaml variable at the top of the method.

[rawlingsj]

ok thanks @rupalibehera! I added a couple of comments.

FWIW I tested the changes using this inline jenkins pipeline script, you can copy / paste it youself into a new Jenkins pipeline job created via the jenkins UI..

@Library('github.com/rupalibehera/fabric8-pipeline-library@issueid-13')
def dummy
mavenNode {
  ws{
      git 'https://github.com/rawlingsj/t3d.git'
      container(name: 'maven') {
          sh 'mvn clean install'
          def flow = new io.fabric8.Fabric8Commands()
          def rs = flow.isOpenShiftS2I()
          echo "${rs}"
      }
  }
}

[rupalibehera]

@rawlingsj , I have tested the above PR as suggested by you and it works fine now, let me know if you have anymore reviews on this ?

[rawlingsj]

Could you rebase this PR please @rupalibehera and we'll get it merged in

[jimmidyson]

What about if this finds multiple files? Should they all be checked or just the first one as you're doing below?

[rupalibehera]

I am not sure if we will have multiple files, as we can see above in the diff we were earlier just checking for one file in the same location now we are just checking for it recursively in the same directory.

[rupalibehera]

@rawlingsj , I have rebased the PR

[rupalibehera]

@rawlingsj , can we merge this one ?

[rawlingsj]

[merge]