Rename apiVersion → apiGroupVersion breaks client #1347
Comments
This was referenced Feb 6, 2019
Merged
|
The change was meant to be internal and shouldn't affect model classes.
Apparently, it leaked to model too. That needs to be fixed.
…On Wed, Feb 6, 2019, 03:30 Jesse Glick ***@***.*** wrote:
What is the rename by @iocanel <https://github.com/iocanel> in #1322
<#1322> about? It
matches neither documentation
<https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#resources>
nor what I observe from kubectl get -o json in a v1.11.5-gke.5 cluster.
In fact using the master version of this library, I get errors such as
com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "apiVersion" (class io.jenkins.x.client.kube.PipelineActivityList), not marked as ignorable (4 known properties: "items", "apiGroupVersion", "kind", "metadata"])
at [Source: ***@***.***; line: 1, column: 16] (through reference chain: io.jenkins.x.client.kube.PipelineActivityList["apiVersion"])
at com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:62)
at com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:834)
at com.fasterxml.jackson.databind.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:1093)
at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownProperty(BeanDeserializerBase.java:1478)
at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownVanilla(BeanDeserializerBase.java:1456)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:282)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:140)
at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:3814)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2931)
at io.fabric8.kubernetes.client.utils.Serialization.unmarshal(Serialization.java:235)
Caused: io.fabric8.kubernetes.client.KubernetesClientException: An error has occurred.
at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:64)
at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:53)
at io.fabric8.kubernetes.client.utils.Serialization.unmarshal(Serialization.java:237)
at io.fabric8.kubernetes.client.utils.Serialization.unmarshal(Serialization.java:190)
at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleResponse(OperationSupport.java:384)
at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleResponse(OperationSupport.java:344)
at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleResponse(OperationSupport.java:328)
at io.fabric8.kubernetes.client.dsl.base.BaseOperation.listRequestHelper(BaseOperation.java:168)
at io.fabric8.kubernetes.client.dsl.base.BaseOperation.list(BaseOperation.java:593)
at io.fabric8.kubernetes.client.dsl.base.BaseOperation.list(BaseOperation.java:70)
at …
from this definition
<https://github.com/jenkins-x/jx-java-client/blob/e78ede5a34484cb9a77f2134edad2f4bf716252f/src/main/java/io/jenkins/x/client/kube/PipelineActivityList.java#L5>.
The error is fixed by reverting the patch to CustomResourceList.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1347>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAYiWCVq_xjbLjF7mM9rTPPqJofErMvdks5vKjAtgaJpZM4akZbu>
.
|
|
I guess this was a case of an overeager rename refactoring? |
|
Yeah!
…On Wed, Feb 6, 2019, 18:14 Jesse Glick ***@***.*** wrote:
I guess this was a case of an overeager rename refactoring?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1347 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYiWP4ybjVFkSTMfq0QKfN2ou3OU32Sks5vKv9tgaJpZM4akZbu>
.
|
|
There are internals where apiVersion meant apiVersionGroup/apiVersionNumber
(which is how k8s treat it) and other where it meant apiVersionNumber. In
the effort to clarify things I overdid it.
…On Wed, Feb 6, 2019, 20:25 Ioannis Canellos ***@***.*** wrote:
Yeah!
On Wed, Feb 6, 2019, 18:14 Jesse Glick ***@***.*** wrote:
> I guess this was a case of an overeager rename refactoring?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1347 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAYiWP4ybjVFkSTMfq0QKfN2ou3OU32Sks5vKv9tgaJpZM4akZbu>
> .
>
|
iocanel
added a commit
that referenced
this issue
Mar 1, 2019
Fix #1347: the JSON property is apiVersion, not apiGroupVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the rename by @iocanel in #1322 about? It matches neither documentation nor what I observe from
kubectl get -o jsonin av1.11.5-gke.5cluster. In fact using themasterversion of this library, I get errors such asfrom this definition. The error is fixed by reverting the patch to
CustomResourceList.The text was updated successfully, but these errors were encountered: