Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenIDConnectionUtils#persistKubeConfigWithUpdatedToken persists access token instead of refresh token #2783

Closed
oliviaKar opened this issue Feb 3, 2021 · 2 comments · Fixed by #2869 or jenkinsci/kubernetes-client-api-plugin#83
Closed

OpenIDConnectionUtils#persistKubeConfigWithUpdatedToken persists access token instead of refresh token #2783

oliviaKar opened this issue Feb 3, 2021 · 2 comments · Fixed by #2869 or jenkinsci/kubernetes-client-api-plugin#83
Assignees
@rohanKanojia
Labels
bug
Milestone
5.2.0

Comments

@oliviaKar
Copy link

https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/OpenIDConnectionUtils.java#L263

Here it seems like the access_token is retrieved from the updated config and persisted as the refresh token.

The behaviour that we have observed is that the config gets refreshed once, but cannot keep getting refreshed as the persisted refresh-token is not valid.
@rohanKanojia
Copy link
Member

@oliviaKar : Thanks a lot for reporting this. Could you please raise a quick PR to fix this?

@manusa manusa added the bug label Feb 8, 2021
@rohanKanojia rohanKanojia self-assigned this Feb 24, 2021
@rohanKanojia
Copy link
Member

@oliviaKar : Hi, Which cloud provider are you using?

@manusa manusa added this to the 5.2.0 milestone Mar 3, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Mar 3, 2021
@rohanKanojia
Fix fabric8io#2783: OpenIDConnectionUtils#persistKubeConfigWithUpdate…
8075729 
…dToken persists access token instead of refresh token
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Mar 4, 2021
@rohanKanojia
Fix fabric8io#2783: OpenIDConnectionUtils#persistKubeConfigWithUpdate…
d0271ff 
…dToken persists access token instead of refresh token
@rohanKanojia rohanKanojia mentioned this issue Mar 4, 2021
Merged
11 tasks
manusa pushed a commit that referenced this issue Mar 5, 2021
@rohanKanojia @manusa
Fix #2783: OpenIDConnectionUtils#persistKubeConfigWithUpdatedToken pe…
00d23e8 
…rsists access token instead of refresh token
This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 16, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Fix #2783: OpenIDConnectionUtils#persistKubeConfigWithUpdatedToken persists access token instead of refresh token rohanKanojia/kubernetes-client
Bump revision from 4.13.2-2 to 5.2.1 jenkinsci/kubernetes-client-api-plugin
Bump kubernetes-client-bom from 5.1.1 to 5.2.0 quarkusio/quarkus
Bump kubernetes-client-bom from 4.10.2 to 5.2.0 ropalka/quarkus
Bump kubernetes-client-bom from 4.10.2 to 5.2.0 xstefank/quarkus
Bump kubernetes-client-bom from 4.13.0 to 5.2.0 snazy/quarkus
Bump kubernetes-client-bom from 5.0.2 to 5.2.0 johnaohara/quarkus
Bump kubernetes-client-bom from 5.0.2 to 5.2.0 eformat/quarkus
Bump kubernetes-client-bom from 5.0.1 to 5.2.0 juazugas/quarkus
Bump kubernetes-client-bom from 5.0.1 to 5.2.0 gwenneg/quarkus
3 participants
@manusa @rohanKanojia @oliviaKar