Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinements for alternative clients #3971

Closed
shawkins opened this issue Mar 15, 2022 · 1 comment
Closed

Refinements for alternative clients #3971

shawkins opened this issue Mar 15, 2022 · 1 comment
Milestone

Comments

@shawkins
Copy link
Contributor

shawkins commented Mar 15, 2022

Is your task related to a problem? Please describe

There are some adjustments needed to the api and usage model.

Describe the solution you'd like

  • The ssl configuration should provide the key and trust managers rather than the context.
  • The WatchHTTPManager should use a different thread to handle the InputStream. Using the thread that calls whenComplete on the returned future is only safe for okhttp.
  • A refinement should be made to interceptors to make non-blocking calls - token refreshes are current blocking

Some additional one-off threads being created by the client:

  • ExecWebSocketListener, LogWatchCallback, and PodUpload for inputstream pumping - these are candidates for refactoring, but require new/different surrounding apis to fully take advantage of new calling styles. PodUpload is already due to be reworked by Remove PodUploadWebSocketListener #3856
  • PortForwarderWebsocket to start a listener thread
  • A shared scheduling thread in Utils

Describe alternatives you've considered

No response

Additional context

No response

@shawkins
Copy link
Contributor Author

shawkins commented Mar 15, 2022

It is not strictly required that responses return strings. Deserialization already accepts inputstream. The only place a string return value is used is with reading logs.

@shawkins shawkins added this to the 6.0.0 milestone Mar 15, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 16, 2022
@shawkins shawkins mentioned this issue Mar 16, 2022
11 tasks
@manusa manusa closed this as completed in b095b78 Mar 22, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant