Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many NonNamespaceOperation methods have been removed in 5.12.1 #4022

Closed
metacosm opened this issue Mar 30, 2022 · 3 comments · Fixed by #4023
Closed

Too many NonNamespaceOperation methods have been removed in 5.12.1 #4022

metacosm opened this issue Mar 30, 2022 · 3 comments · Fixed by #4023
Assignees
Milestone

Comments

@metacosm
Copy link
Collaborator

Describe the bug

#3772 removed some methods from NonNamespaceOperation, which is fine but it also removed methods / interfaces that it shouldn't have. More specifically, Replaceable and Deletable should probably still be part of the NonNamespaceOperation.

Moving forward, for 6.0, it might make sense to trim down the DSL interfaces so that only the orthogonal ones are kept so that it's easier to figure out what an interface actually provides?

Fabric8 Kubernetes Client version

other (please specify in additional context)

Steps to reproduce

N/A

Expected behavior

Non-mutable methods should still be available from NonNamespaceOperation.

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

other (please specify in additional context)

Environment

other (please specify in additional context)

Fabric8 Kubernetes Client Logs

No response

Additional context

This actually targets 5.12.1.

@rohanKanojia
Copy link
Member

I understand Deletable should be part of NonNamespaceOperation but why would we want Replaceable to be under NonNamespaceOperation? As per my knowledge this operation has strict requirement of name.

metacosm added a commit that referenced this issue Mar 30, 2022
@metacosm
Copy link
Collaborator Author

@rohanKanojia I think you're confusing it with something else :)
Plus, you already re-added Replaceable in master: ea07b7f :)

@rohanKanojia
Copy link
Member

ohk, I got my answer. When name is not provided it will be inferred from resource .metadata. Sorry for noise.

metacosm added a commit to quarkiverse/quarkus-operator-sdk that referenced this issue Mar 31, 2022
5.12.1 has an issue that prevents compilation of JOSDK:
fabric8io/kubernetes-client#4022
@manusa manusa added this to the 6.0.0 milestone Apr 1, 2022
metacosm added a commit to quarkiverse/quarkus-operator-sdk that referenced this issue Apr 1, 2022
5.12.1 has an issue that prevents compilation of JOSDK:
fabric8io/kubernetes-client#4022
@manusa manusa modified the milestones: 6.0.0, 5.12.2 Apr 5, 2022
manusa pushed a commit that referenced this issue Apr 5, 2022
@manusa manusa closed this as completed in f66b9e4 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants