Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add missing interfaces #4023

Merged
merged 1 commit into from
Apr 5, 2022
Merged

fix: re-add missing interfaces #4023

merged 1 commit into from
Apr 5, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Mar 30, 2022

Description

Fixes #4022

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@metacosm metacosm self-assigned this Mar 30, 2022
@metacosm metacosm changed the base branch from master to 5.12 March 30, 2022 15:32
@rohanKanojia
Copy link
Member

Could you please add some tests for DSL cases which are reintroduced by this PR?

@metacosm
Copy link
Collaborator Author

Could you please add some tests for DSL cases which are reintroduced by this PR?

Don't really have time for this at the moment… Feel free to add them.

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Deletable is effectively available here via FilterWatchListMultiDeletable

@metacosm
Copy link
Collaborator Author

True but I added it for completeness sake.

@manusa manusa added the 5.12.x Backportable tentative label Apr 1, 2022
@manusa manusa added this to the 6.0.0 milestone Apr 1, 2022
@manusa manusa added the changelog missing A line to changelog.md regarding the change is not added label Apr 1, 2022
@manusa manusa modified the milestones: 6.0.0, 5.12.2 Apr 5, 2022
@manusa manusa merged commit 02d9cd9 into 5.12 Apr 5, 2022
@manusa manusa deleted the fix-4022 branch April 5, 2022 05:08
@manusa manusa removed changelog missing A line to changelog.md regarding the change is not added 5.12.x Backportable tentative labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many NonNamespaceOperation methods have been removed in 5.12.1
5 participants