Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1172 : Use v1beta1 for CronJob #1174

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia
Copy link
Member Author

@iocanel @oscerd @piyush1594 @hrishin : Hm, tests are failing on older Openshift versions because they don't recognize v1beta1 apiVersion. Shall we care about cronjob support on these versions? Any ideas if we can make setting apiVersion somehow configurable in the dsl itself?

@piyush-garg
Copy link
Contributor

@rohanKanojia You need to add the entry here for CronJob also https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/BackwardsCompatibilityInterceptor.java#L109

@piyush-garg
Copy link
Contributor

@rohanKanojia Here tests are failing may be because you forgot to change model version also.

@iocanel
Copy link
Member

iocanel commented Aug 9, 2018 via email

@rohanKanojia rohanKanojia added the needs code review Pull requests which are waiting for review label Aug 16, 2018
@rohanKanojia
Copy link
Member Author

[merge]

@fusesource-ci fusesource-ci merged commit 07f7820 into fabric8io:master Aug 20, 2018
@rohanKanojia rohanKanojia removed the needs code review Pull requests which are waiting for review label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants