Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (kubernetes-client-api) : Fix NO_PROXY check in HttpClientUtil (#4247) #4305

Merged
merged 2 commits into from
Aug 5, 2022
Merged

fix (kubernetes-client-api) : Fix NO_PROXY check in HttpClientUtil (#4247) #4305

merged 2 commits into from
Aug 5, 2022

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jul 27, 2022 •
edited
Loading

Description

Fix #4247

  • Modify NO_PROXY check to use .endsWith instead of .contains to
    better match host name.
  • Add a check to throw an Exception if any of NO_PROXY contains *

Signed-off-by: Rohan Kumar rohaan@redhat.com

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia marked this pull request as ready for review July 27, 2022 14:06
@rohanKanojia @manusa
fix (kubernetes-client-api) : Fix NO_PROXY check in HttpClientUtil (f…
aa76a43 
…abric8io#4247)

+ Modify NO_PROXY check to use `.endsWith` instead of `.contains` to
  better match host name.
+ Add a check to throw an Exception if any of NO_PROXY contains `*`

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa
refactor (kubernetes-client-api): NO_PROXY tests + handling of invali…
c800fac 
…d characters

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa added this to the 6.1.0 milestone Aug 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 3438236 into fabric8io:master Aug 5, 2022
@rohanKanojia rohanKanojia deleted the pr/issue4247 branch August 5, 2022 08:55
@manusa manusa mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawkins shawkins shawkins left review comments

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

Openshift Client ignores NO_PROXY setting
4 participants
@rohanKanojia @manusa @shawkins @oscerd