feat (kubernetes-client-api) : Expose put method with InputStream arguments in HttpRequest #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test for Jetty is missing |
manusa
reviewed
May 9, 2023
kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/http/HttpRequest.java
Outdated
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/feat-http-put-inputstream
branch
2 times, most recently
from
cabb649
to
6ddc209
Compare
manusa
reviewed
May 10, 2023
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| #### Dependency Upgrade | |||
|
|
|||
| #### New Features | |||
| * Fix #5112: Expose put method with InputStream argument in HttpRequest class | |||
There was a problem hiding this comment.
Please, move this to improvements section so it can sort of fit into the patch release category
manusa
reviewed
May 10, 2023
kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/http/HttpRequest.java
Show resolved
Hide resolved
…uments in HttpRequest Related to eclipse-jkube/jkube#1364 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/feat-http-put-inputstream
branch
from
6ddc209
to
edbeedb
Compare
|
SonarCloud Quality Gate failed. |
manusa
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to eclipse-jkube/jkube#1364
We're trying to use Fabric8's Http abstraction in one of our helm-related functionality. We need put method with InputStream in order to do an octet-stream request.
Type of change
test, version modification, documentation, etc.)
Checklist