Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Camel-K extension #5333

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Removed Camel-K extension #5333

merged 1 commit into from
Jul 13, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 13, 2023 •
edited
Loading

Description

Fix #5171

Removed Camel-K extension, users should use org.apache.camel.k:camel-k-crds instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 6.8.0 milestone Jul 13, 2023
@manusa manusa force-pushed the fix/camel-k-extension branch 2 times, most recently from 4403755 to ae57d8c Compare July 13, 2023 08:52
@andreaTP
Copy link
Member

Screenshot 2023-07-13 at 10 14 39 ❤️ LGTM

@oscerd oscerd mentioned this pull request Jul 13, 2023
Closed
@rohanKanojia
Copy link
Member

README needs to be updated as well:

Screenshot_20230713_145146

@manusa
refactor: removed Camel-K extension
700a316 
Use [`org.apache.camel.k:camel-k-crds`](https://central.sonatype.com/artifact/org.apache.camel.k/camel-k-crds) instead.

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa
Copy link
Member Author

manusa commented Jul 13, 2023

README needs to be updated as well:

Should be addressed now

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@manusa manusa merged commit 9db6e48 into fabric8io:master Jul 13, 2023
20 checks passed
@manusa manusa deleted the fix/camel-k-extension branch July 13, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@andreaTP andreaTP andreaTP approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@shawkins shawkins Awaiting requested review from shawkins

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.

Remove Camel-K extension
4 participants
@manusa @andreaTP @rohanKanojia @oscerd