Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded to node 4.8.3 #21

Closed
wants to merge 1 commit into from
Closed

upgraded to node 4.8.3 #21

wants to merge 1 commit into from

Conversation

ruromero
Copy link

@ruromero ruromero commented Jun 29, 2017

Issue
When Openshift CA is generated using another CA, is not possible to login into Kibana and the user is always being redirected to the login page.
This PR is trying to fix BZ https://bugzilla.redhat.com/show_bug.cgi?id=1465022

How to reproduce it

  1. Configure inventory with custom CA.
  2. Regenerate CA and Certificates using ansible
    ansible-playbook playbooks/byo/openshift-cluster/redeploy-openshift-ca.yml
  3. Regenerate Certificates using ansible
    ansible-playbook playbooks/byo/openshift-cluster/redeploy-certificates.yml
  4. Deploy logging using default values
  5. Access Kibana page and try to login

How to confirm it is resolved

  1. Clone the project
  2. Build image to deploy it to the local registry
    docker build -t <registry_svc_ip>:5000/logging/openshift-auth-proxy:0.1.1 .
  3. Login using a valid account
    oc login -u admin -p xxxx https://openshift.example.com:8443
  4. Push built image to local registry
    docker push <registry_svc_ip>:5000/logging/openshift-auth-proxy:0.1.1
  5. Edit the deploymentConfig to use this image and a new build will take place
  6. Login into Kibana

Additional info
Tests have confirmed that the login loop does not happen on nodejs 4.8.3 when using certificates generated from an intermediate CA.
Actually I have verified that the fix was introduced between 4.8.0 and 4.8.1

@jcantrill
Copy link
Contributor

@richm Any knowledge if this version is available to us downstream?

@ruromero Can you please open an issue in this repo describing:

  1. The issue
  2. How you reproduced it
  3. How you confirmed it is resolved.

This will give us tractability and something to fall back on and reference.

@jcantrill
Copy link
Contributor

@ruromero Maybe you can update #18

@Jooho
Copy link

Jooho commented Jun 30, 2017

@ruromero @jcantrill I tried to change nodejs version to 4.8.3 but still I encounter issue.

Actually, I am not sure my issue is because of nodejs version because I got this error message:

in passport.ensureAuthenticated for req path /auth/token
not authenticated by request session.
in validateBearerToken

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: SELF_SIGNED_CERT_IN_CHAIN
    at SecurePair.<anonymous> (tls.js:1429:32)
    at SecurePair.emit (events.js:92:17)
    at SecurePair.maybeInitFinished (tls.js:1028:10)
    at CleartextStream.read [as _read] (tls.js:520:13)
    at CleartextStream.Readable.read (_stream_readable.js:341:10)
    at EncryptedStream.write [as _write] (tls.js:417:25)
    at doWrite (_stream_writable.js:226:10)
    at writeOrBuffer (_stream_writable.js:216:5)
    at EncryptedStream.Writable.write (_stream_writable.js:183:11)
    at write (_stream_readable.js:602:24)

@ruromero
Copy link
Author

ruromero commented Jun 30, 2017

@jcantrill I have updated the description
@Jooho looking at the BZ you opened I think the problem you are having is that the connection established from Kibana is not trusting the certificate because it lacks the whole chain.
A simple way to test it is using oadm ca create-signer-cert --key="customca.key" --cert="customca.crt" --serial="customca.serial.txt" --name="CustomCA Example Ltd" and then use this to generate Openshift's CA and then the certificates.
Or else, if you need to use your own CA, be sure you're including the whole chain

@Reamer
Copy link
Contributor

Reamer commented Jun 18, 2018

I think we can close this merge-request, because node 4.8.3 is end-of-life. Take a look at #30

@ruromero ruromero closed this Jun 23, 2018
@ruromero ruromero deleted the 1465022_node_483 branch June 23, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants