Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more input validation tests #27

Closed
2 tasks done
fabrice-rossi opened this issue Aug 19, 2022 · 1 comment
Closed
2 tasks done

Add more input validation tests #27

fabrice-rossi opened this issue Aug 19, 2022 · 1 comment
Labels
improvement
Milestone
0.2.0

Comments

@fabrice-rossi
Copy link
Owner

fabrice-rossi commented Aug 19, 2022 •
edited
Loading

Many functions do not validate enough their parameters before calling low level functions, leading to non informative error messages. In particular:

  • likelihood does not check the compatibility of the newdata (see simulate.vlmc() for the validation code).
  • draw.covlmc() does not validate model
@fabrice-rossi
Copy link
Owner Author

Work in progress starting with commit 11c50e8.

fabrice-rossi added a commit that referenced this issue Apr 8, 2023
@fabrice-rossi
Add more tests on the input values (Issue #27)
3666bb6
fabrice-rossi added a commit that referenced this issue Apr 8, 2023
@fabrice-rossi
Add more parameter validation (Issue #27).
4b042e5
fabrice-rossi added a commit that referenced this issue Jul 8, 2023
@fabrice-rossi
Add newdata validation code (see issue #27).
e33a68e
@fabrice-rossi fabrice-rossi added this to the 0.2.0 milestone Sep 9, 2023
fabrice-rossi added a commit that referenced this issue Sep 16, 2023
@fabrice-rossi
Add parameter check (issue #27).
d538998
fabrice-rossi added a commit that referenced this issue Sep 16, 2023
@fabrice-rossi
Add a more complete input validation test (issue #27).
5912a1e
fabrice-rossi added a commit that referenced this issue Oct 8, 2023
@fabrice-rossi
Add alpha parameter check (issue #27).
c887e5b
fabrice-rossi added a commit that referenced this issue Oct 25, 2023
@fabrice-rossi
Add alpha parameter check (issue #27).
58662d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@fabrice-rossi