Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable post-pruning for covlmc models #8

Closed
fabrice-rossi opened this issue Jul 14, 2022 · 2 comments
Closed

Enable post-pruning for covlmc models #8

fabrice-rossi opened this issue Jul 14, 2022 · 2 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@fabrice-rossi
Copy link
Owner

The cutoff and prune functions for vlmc enable an efficient search for an optimal model according to e.g. the BIC. A similar functionality for covlmc models would be very useful, especially considering that the estimation time for those models is significantly longer than for vlmc models.

The ground work for cutoff has already been implemented in commit a9600eb.

Post pruning needs the data to be saved in the covlmc but the added memory consumption should be compensated by the reduced total processing time when we look for an optimal model. Models fitted to the data but discarded could also be saved to speed up the process even more.

@fabrice-rossi
Copy link
Owner Author

The series of commits referencing this issue implement a first working version of the feature. Storing the models discarded during the first run of the algorithm (in covlmc) could speed up the pruning process, but this is non obvious as any modification in the deeper part of the tree can impact all the models above.

@fabrice-rossi
Copy link
Owner Author

Optimisation postponed to feature #15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant