chore(lint): disallow Math.hypot, window, document (#8277)

fabricjs · Sep 12, 2022 · 2ef70cf · 2ef70cf
1 parent 938033a
commit 2ef70cf
Show file tree

Hide file tree

Showing 4 changed files with 111 additions and 98 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -14,5 +14,27 @@ module.exports = {
   ],
   rules: {
     '@typescript-eslint/ban-ts-comment': 1,
+    'no-restricted-globals': [
+      'error',
+      {
+        name: 'window',
+        message: 'Use fabric window or other utils instead.'
+      },
+      {
+        name: 'document',
+        message: 'Use fabric document or other utils instead.'
+      }
+    ],
+    'no-restricted-syntax': [
+      'error',
+      {
+        selector: '[callee.object.name="Math"][callee.property.name="hypot"]',
+        message: '`Math.hypot` is not accurate on chrome, import `hypot` from `util` instead.'
+      },
+      {
+        selector: 'VariableDeclarator[init.name="Math"]',
+        message: 'Aliasing or destructing `Math` is not allowed due to restrictions on `Math.hypot` usage.'
+      }
+    ]
   },
 };
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -160,6 +160,17 @@
       {
         "ignoreComments": true
       }
+    ],
+    "no-restricted-syntax": [
+      "error",
+      {
+        "selector": "[callee.object.name='Math'][callee.property.name='hypot']",
+        "message": "`Math.hypot` is not accurate on chrome, import `hypot` from `util` instead"
+      },
+      {
+        "selector": "VariableDeclarator[init.name='Math']",
+        "message": "Aliasing or destructing `Math` is not allowed due to restrictions on `Math.hypot` usage"
+      }
     ]
   }
 }