Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧐 Breaking changes for fabric 6.0 #8299

Open
asturur opened this issue Sep 18, 2022 · 144 comments
Open

🧐 Breaking changes for fabric 6.0 #8299

asturur opened this issue Sep 18, 2022 · 144 comments
Labels

Comments

@asturur
Copy link
Member

asturur commented Sep 18, 2022

b.0.0-beta16

This list is in progress and is meant to be an easy go to place to add things and find them when the time comes to write a document on what has changed.
This will be a list of descriptive items, extended as needed to capture behavior changes.
Apart from what is described here MANY bugs have been fixed in the process.

Generic concepts

  • Imports we moved from import { fabric } from 'fabric' to import { Canvas, Rect, util } from 'fabric' or import * as fabric from 'fabric'. To avoid packaging issues node has its own entrypoint import { StaticCanvas } from 'fabric/node'. This means there is no fabric namespace/object anymore.

  • method chaining is now deprecated, don't use it anymore. Not all methods were chainable, and chaining seems to offer limited advantages ( maybe saving 1-2 bytes in the code you write when minified? unsure what else ). Just for consistency sake and to be free to start returning useful information from some methods we will stop using it. We didn't remove it from everywhere so that there isn't unnecessary breakage, but you should consider that unsafe to use, since will break entirely on the next major release after 6.0
    ( add detailed list of where has been removed so far )

  • Callbacks are mostly gone, all of the functions that took a callback now return a Promise, this on top of being breaking slightly alter code behavior when is fixed. Before sync code would execute the callback synchronously, now is chained to however the browser handle the promise ( not sure if it goes in the event loop and under which circumstances ). Promises support #3684

  • TS: The code base is typed! If you used @types/fabric you should uninstall it

  • Prototype Mutation:
    Fabric has moved to native classes. No more createClass or object.util.extend. You can still mutate the prototype, however, properties do not exist on the prototype in native classes. Look into getDefaults instead.

  • scene vs. viewport
    We introduced these concepts to describe the rendering/view planes as follows: The viewer is viewing the scene (what is rendered/"playing") from the viewport. The scene was considered is the past as the absolute plane whereas the viewport wasn't feat(Canvas): provide correctly named canvas pointer methods. BREAKING: rm _normalizePointer, restorePointerVpt #9175.
    Normally geometry calculations occur in the scene with the exception of padding which is a viewport scalar.

    • All events have a scenePoint and viewportPoint properties replacing the deprecated and confusing absolutePointer and pointer properties. Brushes are still in need of this change.
    • dep Canvas#getPointer in favor of getScenePoint or getViewportPoint
    • Using viewportTransform is rather confusing with this change (especially with sendPointToPlane etc.) perhaps be renaming to sceneTransform is the correct migration path in the future.
  • React Compatibility:

    • Ensure proper disposal in useEffect, especially with React 18. Refer to this hook for guidance.
    • Async Disposal: Handle async nature of dispose method. The asynchronous disposal of Canvas and StaticCanvas safeguards an edge case in which dispose is called while rendering is still in progress. This should burden your react app.
    • DOM Mutation: Fabric modifies the DOM and cleans up after itself as long as Canvas#dispose is called

Collection

  • not available as a standard object as fabric.Collection any longer, was never meant to, it was a constrain of the previous build system ( we had no imports or require or bundling before ).
  • insertAt method signature changed from insertAt(object, index) to insertAt(index, ...objects)
  • Collection now owns the stack too, methods were renamed to accommodate Group:
    • sendObjectToBack sendToBack
    • bringObjectToFront bringToFront
    • sendObjectBackwards sendBackwards
    • bringObjectForward bringForward
    • moveObjectTo moveTo
  • Support to stack operations with active selection is gone

Canvas and StaticCanvas

  • Canvas.dispose and StaticCanvas.dispose are now async In order to handle some concurrency issue with requestAnimationFrame, dispose is now checking and waiting for any uncancellable render to finish. This could have some side effects, especially in complex environments with UI frameworks and hot reload of code.

  • trying to initialize a canvas that has already been initialized fix(Canvas): Safeguard from multiple initialization #7776 is not breaking, it saves the dev from a silent breakage that they weren't aware of

  • removed canvas.straightenObject wasn't really useful.

  • changed cloneWithoutData , now it does not clone backgrounds.

  • canvas.clone now correctly return either a canvas or staticCanvas

  • drawClipPathOnCanvas signature changed: now accepts the clipPath as a second argument instead of rechecking its existence

  • getCenter renamed to getCenterPoint dep(Canvas#getCenter): migrate to getCenterPoint #7699

  • add returns the length of the array of objects after adding, like Array#push

  • remove returns an array with the removed objects inside

  • insertAt method signature changed (refer to the Collection section)

  • removed sendToBack, bringToFront, sendBackward, moveTo, bringForward ( and gained similar methods from collection (refer to the Collection section)

  • Canvas#freeDrawingBrush is not set by default

  • scene vs. viewport changes

    • dep getPointer in favor of getScenePoint or getViewportPoint
    • rm _normalizePointer, restorePointerVpt
  • rm interactive flag, use instance of Canvas instead

  • rm setBackgroundColor, setBackgroundImage, setOverlayColor, setOverlayImage: assign the property directly and render the canvas

Object

  • BREAKING Coords system improvements:
    • removed lineCoords
    • aCoords should be treated as protected , if you need the scene corners of an object use getCoords
    • fixed coords to respect grouping and nesting, see the Group section
    • removed absolute, calculate from geometry methods signatures (all listed methods operate in the scene):
      • getCoords
      • intersectsWithRect
      • intersectsWithObject
      • isContainedWithinObject
      • isContainedWithinRect
      • getBoundingRect
      • containsPoint changed signature entirely and fixed
    • getRelativeXY/setRelativeXY to get/set the coordinate in the parent plane, getXY/setXY to get/set the coordinate in the scene plane
    • adjustPosition is gone. It took a parameter only, was internally unused, didn't take care of internal edge cases setPositionByOrigin is more flexible
    • rm _setOriginToCenter and _resetOrigin change(): rm _setOriginToCenter and _resetOrigin #9179
    • Control coords (oCoords) are calculated only if the object has a canvas ref
  • type has become a static field and should be used only for serialization with classRegistry. There is still a deprecated getter on the object for compatibility reasons. Avoid using it.
  • Object looses the stack methods, instead of guessing which was the stack we refer to when we move forward/backward we do that from the stack itself BREAKING(Object Stacking): 🔙 refactor logic to support Group 🔝 #8461, see the Collection section
  • stateful functionality is deprecated, is officially removed, but is still reacheable. Don't use it. Comparing large set of propeties to detect a change doesn't really play well neither with performance nor with edge cases. stateful and statefulCache are removed. stateful was used to fire an object modified every render cycle in which a change in state properties was determiend. All the events that can modify an object already fire an object:modified event, and the user has no ability to change colors or state outside developer written code, so there is no really need for event firing here. statefulCache was an experiment and the suggestion to use set(property, value) replaced it since long. FabricJS internally still use some stateful logic for now, but the intention is to get rid of it.
  • methods like center, centerH, centerV, viewportCenter are gone. Those were aliases for the canvas methods, use them instead.
  • animate changed to adapt to animation changes
  • The controls object is not shared between instances - it is not on the prototype as all class fields
  • BREAKING: Object#getObjectScaling, Object#getTotalObjectScaling now returns Point instead of {scaleX,scaleY} BREAKING chore(): Reuse fabric.Point logic for scaling and naming consistency #7710

Text

  • see Text styles under the Serialization section
  • rename data-fabric-hiddentextarea to data-fabric with value textarea, if you were using hasAttribute('data-fabric-hiddentextarea') now you have to use getAttribute('data-fabric') and then check for equality with textarea or change your cssSelector accordingly.
  • _getStyleDeclaration returns an empty object instead of undefined when style is not set.
  • controls can be used in editing mode

Polyline Polygon Path

  • _setPositionDimensions (considered private in the past), has been renamed to setDimensions. The logic with which Polyline based object calculate the size is changed. There wasn't an api in 5.x to change the size, but devs needed to do it anyway and the alternative was to create a new object. Is not called setPositionAndDimensions because the logic to correcly change size while keeping a visual correct position is not there yet and maybe it won't.
  • exposed long desired poly controls createPolyControls

Group

  • complete rewrite described in V6: 🎉 Group Rewrite #7670
  • CONCEPT: Group rewrite exposes a change in concept - strict object tree. An object can belong to one parent.
  • exposed the parent property on FabricObject alongside group to allow an object to return to its parent after being deselected from an active selection.
  • addWithUpdate is gone, now add does what it has to do.
  • LayoutManager has been introduced to handle group layout refactor(): Layout Manager #9152. By default it will be fit-content, meaning the group will fit around its objects, updating when objects are added/removed/modified.

Controls

Serialization

  • Text#styles is now exported differently. This is BREAKING only if you are handling the style object post export The default object we exported was large most of the time, with tons of empty keys and verbosity. It seems reasonable to think that most of the time text is styled in some chunk of text with coherent different styles ( eg: a red word in a black text or some words underlined and some not more than a rainbow of different stylings per object ) for that reason we changed the approach of serialization to an array with start and end index for the style. We didn't apply that to actual runtime code because we were unsure of performance, so at least for version 6, styles at runtime are going to be the same. It is highly recommended to not fiddle with the style object directly and to treat it as internal, using the public facing methods to apply changes. feat(Text): condensed styles structure v6 #8006
  • populateWithProperties => pick populate with properties was used internally to add the extra options to exported objects. Between spread operator and new syntax, a generic pick approach seemed more correct.
  • toJSON is not an alias of toObject. This was a long standing bug, but also a breaking change. toJSON never accepted additional properties and will give you only the default object export. toJSON is meant for JSON#stringify interoperability and is not meant to be used in your code base directly. reference fix(): weird toJson bug #8111
  • classRegistry => register your subclasses to use them during serialization
  • NUM_FRACTION_DIGIT moved to config and incremented from 2 to 4

Brushes

PatternBrush: removed the getPatternSrcFunction. Wasn't working anymore since the refactor of Pattern and also a super weird practice.

Animation

  • animation util does not accept anymore the += or -= syntax for changes, nor accept the byValue option. You can specify an animation only by startValue and endValue.
  • Every animation returns a class with a cancel method to cancel the animation.
  • Animation callback onChange and onComplete will fire for every animation generated by set of properties. This change is necessary because if we assign the callbacks to only one animation, in case that animation will be cancelled, the other ones won't have any registered callback.

Utils

  • makeBoundingBoxFromPoints signature change. The transformation is not supported anymore and requires real points
  • removal of all the array utils ( min, max, find those are well covered by es6 now and also is out of fabric scope to provide generic data manipulation utils )
  • some utils are considered internal and not exposed anymore ( TODO add list )
  • clone and extend have been removed. Those were used in all examples unfortunately so the community has likely adopted them, consider migrating to a well known common library for those functionalities ( lodash, underscore ... ). Avoid using such utilities on classes.
  • makeElementSelectable and makeElementUnselectable are removed. Those were needed internally and one of them is still used internally, but is not a fabricJS core functionality and not part of the api anymore.
  • exposed sendObjectToPlane, sendPointToPlane, sendVectorToPlane to ease common usages of linear algebra. Check them out, you will benefit from it.
  • exposed more vector utils

Misc

@asturur asturur pinned this issue Sep 18, 2022
@asturur asturur changed the title Breaking changes for fabric 6.0 🧐 Breaking changes for fabric 6.0 Sep 18, 2022
@ShaMan123
Copy link
Member

ShaMan123 commented Sep 19, 2022

@asturur
Copy link
Member Author

asturur commented Sep 19, 2022

i ll keep formatting the top post to be the reference to read. I ll threat this asyncronously, feel free to continue add known changes if you know them. i was planning to revisit all the PRs and extract

@ShaMan123
Copy link
Member

ShaMan123 commented Sep 19, 2022

What do you think about planting console.warn in highly breaking stuff that won't surface as errors?

@asturur
Copy link
Member Author

asturur commented Sep 19, 2022

we can with the /* dev mode */ thing

@ShaMan123
Copy link
Member

I think it is better to add an internal util and use rollup to remove console logs or use an env var or something
Those comments are useless now, right?

@ShaMan123
Copy link
Member

ShaMan123 commented Sep 20, 2022

from http://fabricjs.com/v6-breaking-changes:

@ShaMan123
Copy link
Member

@ShaMan123
Copy link
Member

How about we release v6.0.0 with warnings and v6.0.1 without?

@ShaMan123
Copy link
Member

Or add an option to config? or both

@asturur
Copy link
Member Author

asturur commented Sep 20, 2022

I think it is better to add an internal util and use rollup to remove console logs or use an env var or something Those comments are useless now, right?

Are useless now but can be activated, can safely become dead code removal with a rollup plugin that swap the comment with a falsy if, with or without an utility to log.
Let's keep this thread for logging more than discussing or it get noisy fast

@ShaMan123
Copy link
Member

OK I will PR an option I have in mind and we discuss there

@asturur
Copy link
Member Author

asturur commented Sep 20, 2022

OK I will PR an option I have in mind and we discuss there
Preferably something at build time, no runtime

@ShaMan123 ShaMan123 added the v6 label Oct 14, 2022
@ShaMan123
Copy link
Member

ShaMan123 commented Oct 15, 2022

Polyline/Polygon/Path _setPositionDimensions => setDimensions #8344

@rogeriochaves
Copy link

Group has no longer the method addWithUpdate, only add

@asturur
Copy link
Member Author

asturur commented Oct 28, 2022

From latest TS pr:
some chainability removed: setCoords, scale, scaleToWidth, scaleToHeight
adjustPosition is gone ( what it was even for? )

Going to update all the upper main description now

@asturur
Copy link
Member Author

asturur commented Nov 20, 2022

BREAKING insertAt signature - (objects, index) => (index, ...objects). Done to comply with the rest of the methods and resemblance to Array.splice
BREAKING removed fabric.Collection, but I can put it back

@ShaMan123
Copy link
Member

ShaMan123 commented Dec 14, 2022

toLocalPoint => controlsUtils.getLocalPoint or unexported normalizePoint

@asturur
Copy link
Member Author

asturur commented Dec 29, 2022

Added all the breaking changes from #8461 and #8519

@asturur
Copy link
Member Author

asturur commented Jan 3, 2023

Need to add the breaking changes from repacking the lib, as soon as export work i can have a full list

@asturur
Copy link
Member Author

asturur commented Jan 9, 2023

Added breakign changes from animation simplification and the removal of canvas aliases on object

@ShaMan123
Copy link
Member

This is a great practice, we should stick to it now on for future versions

@ShaMan123
Copy link
Member

EraserBrush isn't part of v6 yet, so that is breaking for now #8499

@ShaMan123
Copy link
Member

moved to native classes => no more createClass

@ouya99
Copy link

ouya99 commented Dec 7, 2023

@Smrtnyk i see #7670 many groundbreaking changes. regarding basic drawing and moving objects and object handlers... it has lots of changes, right? any samples how to deal with new API?

@ouya99
Copy link

ouya99 commented Dec 8, 2023

Does v6 fix an issue with webview going to cpu 100% when drawing that i have in v5?

@stevenhurth
Copy link

I’m not sure if this is intentional or not, so figured I’d ask before filing a bug.

With version 6 (beta 16), exportable groups do not respect the excludeFromExport option on the objects within the group itself. It just exports them all toSVG regardless of the flag.

I’ve extended the class and override the toSVG method, checking if each object is excludeFromExport. However, it seems like something that I’d expect.

@stevenhurth
Copy link

stevenhurth commented Dec 9, 2023

Another thing I noticed with v6 (beta 16), is that the SVG src for images does not escape the query string. This invalidates the xlink, as the url is invalid.

For example, if I have a url pointing to my server, and pass in the query string, “?format=jpg&quality=80”, the query string should be escaped, “?format=jpg&(amp;)quality=80” (without parens)

We’d only want this for exporting the SVG image url, meaning that the method, getSvgSrc() on image seems like it shouldn’t be deprecated?

I’ve overridden the image class to handle the escaping in the getSvgSrc() method, but it has a deprecation notice on it.

@ShaMan123
Copy link
Member

@stevenhurth @ouya99 file an issue

@ouya99
Copy link

ouya99 commented Dec 11, 2023

@ShaMan123 how to file an issue on a mobile app project? i cannot provide full code sample. i tested my react-native-webview with the most basic fabricjs canvas (isDrawingMode = true) and it produces 100% on cpu.

@yafkari
Copy link

yafkari commented Dec 18, 2023

I don't know if someone experienced this already, but in local with NextJS (react 18), when I dispose the canvas (I await it to be disposed), it works fine.

But when deployed (on vercel), I get the error: Error: fabric: Trying to initialize a canvas that has already been initialized. Did you forget to dispose the canvas?

I tried to put reactStrictMode to false (like it is in prod) but didn't help to reproduce in local

@ShaMan123
Copy link
Member

@yafkari please open a bug report

@sambautista
Copy link

Hello! was the cloneAsImage removed as well on version 6?

@yuvalkarmi
Copy link

yuvalkarmi commented Dec 27, 2023

For folks coming here in late 2023 / early 2024, I was looking for v6 documentation and couldn't find it (let me know if I missed it), so I went through all the comments (including the first one) and summarized what's new so far, and some gotchas people have experienced. Hope this helps:

Fabric v6 Changes So Far:

General Changes

  • Imports: Change from import { fabric } from 'fabric' to import { Canvas, Rect, util } from 'fabric' or import * as fabric from 'fabric'. For Node.js, use import { StaticCanvas } from 'fabric/node'.

  • Register Font: Node's registerFont has been removed. Use registerFont from node canvas.

  • Method Chaining Deprecated: Avoid method chaining as it will be removed in future releases.

  • Callbacks to Promises: Functions with callbacks now return Promises.

  • TypeScript Support: The code base is now typed. Remove @types/fabric if used.

  • Prototype Mutation: Moved to native classes. Use getDefaults instead of mutating the prototype.

Collection

  • Collection Object: No longer standard on fabric.Collection.

  • InsertAt Method: Signature changed from (object, index) to (index, ...objects).

  • New Methods: Methods like sendObjectToBack, bringObjectToFront, sendObjectBackwards, bringObjectForward, and moveObjectTo added.

Canvas and StaticCanvas

  • Canvas.dispose and StaticCanvas.dispose: Now async.

  • Removed Methods: canvas.straightenObject and others.

  • Changed Methods: cloneWithoutData, canvas.clone, insertAt, and others.

  • New Return Values: add returns length of object array, remove returns an array of removed objects.

Animation

  • Animation Syntax: Removed +=, -= syntax and byValue option.

  • Animation Cancelation: Every animation returns a class with a cancel method.

Utils

  • BoundingBox: makeBoundingBoxFromPoints signature changed.

  • Removed Utils: Array utils and others removed or considered internal.

Object

  • Removed Methods: adjustPosition and others.

  • Deprecated Stateful Functionality: Avoid using stateful and statefulCache.

  • Control Object: Not shared between instances.

Text

  • Text Styles: Exported differently.

  • Hidden Textarea: Renamed data attribute.

Polyline, Polygon, Path

  • Set Dimensions: Renamed _setPositionDimensions to setDimensions.

Group

  • AddWithUpdate Removed: Now use add.

  • Group Rewrite: Significant changes in group handling.

Serialization

  • Text Styles: Exported in a condensed structure.

  • ToJSON and ToObject: Differently handled.

  • Class Registry: Register subclasses for serialization.

  • NUM_FRACTION_DIGIT: Moved to config, increased precision.

Brushes

  • PatternBrush: getPatternSrcFunction removed.

Notable Feature Additions

  • Observable Disposer: Returns a disposer function.

  • Point Methods: New methods for fabric.Point.

  • Group Rewrite: Redefined object tree concept.

  • Canvas Initialization: Safeguards against multiple initializations.

Other Notes (Summary from Comments So Far):

  • React Compatibility: Ensure proper disposal in useEffect, especially with React 18.

  • DOM Mutation: Fabric modifies the DOM; ensure proper cleanup.

  • Async Disposal: Handle async nature of dispose method.

Asynchronous Canvas Disposal

The asynchronous disposal of Canvas and StaticCanvas, especially in React 18, requires careful handling in useEffect to avoid reinitialization issues.

DOM Mutation and Cleanup

Fabric.js's manipulation of the DOM for the Canvas class requires specific strategies for cleanup to prevent issues, especially in frameworks like React.

Detailed Group Class Changes

The Group class has significant changes affecting the object tree and management within groups, necessitating adjustments in code.

Handling of SVG Sources and Query Strings

Developers need to address escaping query strings in SVG image URLs, particularly when using external image sources.

@ShaMan123
Copy link
Member

@yuvalkarmi thanks! I will update the first comment with your excellent input and go through the last batch of the changelog.

Documentation is in progress, we should announce it ASAP @asturur

תודה

@ShaMan123
Copy link
Member

updated description to beta16

@lldartsll
Copy link

Hello,
since
setBackgroundColor, setBackgroundImage, setOverlayColor, setOverlayImage are removed
is there an alternative to those functions?
Thanks

@yuvalkarmi
Copy link

yuvalkarmi commented Dec 30, 2023 via email

@lldartsll

This comment was marked as resolved.

@ShaMan123
Copy link
Member

Thanks @yuvalkarmi , that is the migration path.
However I personally prefer what @lldartsll suggests because of stack handling/order considerations.
Both will get the job done.
If it were up to me I would remove the background/overlay concept, too specific to be included in fabric core.
Happy v6

@ShaMan123
Copy link
Member

regarding concerns about async disposing please refer to the hooks in #9577

@JeremyMees

This comment was marked as off-topic.

@ShaMan123
Copy link
Member

@JeremyMees open a bug report, this is not the place for it

@navan101
Copy link

6.0.0-beta-16: getBoundingRect(absolute, calculate) not working when set rotate

@xeoshow
Copy link

xeoshow commented Feb 15, 2024

Hello,

I am new to fabric.js, and just would like to know: How about the performance change compared 6.0.0-beta-XX to 5.X.X?
Thanks a lot.

Best regards, Jason

@asturur
Copy link
Member Author

asturur commented Feb 15, 2024

Hello,

I am new to fabric.js, and just would like to know: How about the performance change compared 6.0.0-beta-XX to 5.X.X? Thanks a lot.

Best regards, Jason

We didn't measure any performance change.
We didn't change any fundamental rendering routine nor caching strategy.
Any change you may experience may come from:

  • different code transpiling
  • classes vs functions
  • reworks on coordinates and bounding box logic

I don't expect any noticeable difference but was my intention to replicate the bunny benchmark test in both 5.x and 6 and verify they are similar

@hqw567
Copy link

hqw567 commented Feb 28, 2024

Hi @asturur , Will the stable version of v6 be released this year? Is there a V6 version of the document available?

@asturur
Copy link
Member Author

asturur commented Mar 12, 2024

Hi @asturur , Will the stable version of v6 be released this year? Is there a V6 version of the document available?

@hqw567 in theory we are 2 pr away to drag a line and call 6.0 with whatever minor bugs and undersights we have.
There is no documentation, i m still batlling with setting up an entirely new website.

@ShaMan123
Copy link
Member

Support to ActiveSelection stack operation is gone
canvas.sendBackwards(activeSelection) will cause a bug in current beta
see #9730

@ShaMan123
Copy link
Member

The eraser for v6 is live at https://github.com/ShaMan123/erase2d

@emielmolenaar
Copy link

Sorry for being off-topic but I just wanted to say a big thanks to everyone working on this massive effort. Legends! 👍🏻

@fabricjs fabricjs deleted a comment from Clemweb Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests