Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): fire contextmenu event #7714

Merged
merged 2 commits into from
Mar 30, 2022
Merged

feat(): fire contextmenu event #7714

merged 2 commits into from
Mar 30, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Feb 20, 2022

fire contextmenu:before, contextmenu
these are useful for devs

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.32 |    76.76 |   86.53 |   83.05 |                                               
 fabric.js |   83.32 |    76.76 |   86.53 |   83.05 | ...,29681,29806,29886-29951,30074,30173,30390 
-----------|---------|----------|---------|---------|-----------------------------------------------

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.32 |    76.76 |   86.53 |   83.05 |                                               
 fabric.js |   83.32 |    76.76 |   86.53 |   83.05 | ...,29681,29806,29886-29951,30074,30173,30390 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.27 |    76.72 |   86.53 |   82.99 |                                               
 fabric.js |   83.27 |    76.72 |   86.53 |   82.99 | ...,29681,29806,29886-29951,30074,30173,30390 
-----------|---------|----------|---------|---------|-----------------------------------------------

@stale
Copy link

stale bot commented Mar 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Mar 13, 2022
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Mar 14, 2022
@asturur
Copy link
Member

asturur commented Mar 30, 2022

I m ok with this, but at the next occasion update the fires section of the canvas documentation. (@fires contenxtMenu... ) Try to make the example of why you need both in the docs ( i m sure using prevent default in the native event does not stops firing contextMenu, so i don't see the reason for contextmenu:before )

@ShaMan123
Copy link
Contributor Author

The reason is that canvas is fired with the event first but what if you want the target to handle the event.
Then the before event is useful.

@ShaMan123 ShaMan123 merged commit ed00026 into master Mar 30, 2022
@ShaMan123 ShaMan123 deleted the contextmenu-event branch April 3, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants