Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): better cli #7825

Merged
merged 24 commits into from Mar 26, 2022
Merged

feat(ci): better cli #7825

merged 24 commits into from Mar 26, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Mar 22, 2022 •
edited

This PR aims to make local dev of fabric easier for the new comer and the seasoned maintainer. So the community can take part easily.
Test suite is quite horrible in terms of DX, this should improve it drastically.

  1. Refactored scripts/cmds to be os agnostic (some didn't work on windows). They should all work, please confirm on MacOS
  2. Added a debug flag for visual tests to recreate a golden file for the dev to compare changes (this means we need to relay of a PR I made to qunit or simply use my branch)
  3. Added a start script that handles what's needed to dev via fabricjs.com
  4. Consolidated all scripts under one executable

In Action

ezgif.com-gif-maker.2.mp4
ezgif.com-gif-maker.1.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.64 |   86.38 |   82.96 |                                               
 fabric.js |   83.23 |    76.64 |   86.38 |   82.96 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.64 |   86.38 |   82.96 |                                               
 fabric.js |   83.23 |    76.64 |   86.38 |   82.96 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |     76.6 |   86.38 |    82.9 |                                               
 fabric.js |   83.18 |     76.6 |   86.38 |    82.9 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.64 |   86.38 |   82.96 |                                               
 fabric.js |   83.23 |    76.64 |   86.38 |   82.96 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |     76.6 |   86.38 |    82.9 |                                               
 fabric.js |   83.18 |     76.6 |   86.38 |    82.9 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.17 |    76.56 |   86.38 |   82.89 |                                               
 fabric.js |   83.17 |    76.56 |   86.38 |   82.89 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |     76.6 |   86.38 |    82.9 |                                               
 fabric.js |   83.18 |     76.6 |   86.38 |    82.9 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.64 |   86.38 |   82.96 |                                               
 fabric.js |   83.23 |    76.64 |   86.38 |   82.96 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.64 |   86.38 |   82.96 |                                               
 fabric.js |   83.23 |    76.64 |   86.38 |   82.96 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |     76.6 |   86.38 |    82.9 |                                               
 fabric.js |   83.18 |     76.6 |   86.38 |    82.9 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.22 |     76.6 |   86.38 |   82.95 |                                               
 fabric.js |   83.22 |     76.6 |   86.38 |   82.95 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 requested a review from asturur March 25, 2022 20:36
@asturur
Copy link
Member

asturur commented Mar 25, 2022

going to run those tomorrow morning.
It is important to add PR descriptions Schahar. Imagine you have to sell the PR to someone, every single time.

@asturur asturur self-assigned this Mar 25, 2022
@ShaMan123
Copy link
Contributor Author

@asturur PR description take 2

ShaMan123
ShaMan123 commented Mar 26, 2022
View reviewed changes
CONTRIBUTING.md
@@ -48,12 +42,29 @@ Contribute to fabricjs using a fully featured online development environment tha

### Setting up a local environment
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section be a standalone section or should it reside under the PR section?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |     76.6 |   86.38 |    82.9 |                                               
 fabric.js |   83.18 |     76.6 |   86.38 |    82.9 | ...,29869,29994,30074-30139,30262,30361,30578 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur
Copy link
Member

asturur commented Mar 26, 2022

Thank you for updatind the description, one the question i had was indeed how to run a single test.
Nice CLI!
Merge if you don't want to change anything else

@asturur
Copy link
Member

asturur commented Mar 26, 2022

Well i ll merge it now because it will help with running test on my pr

@asturur asturur merged commit 7b8444d into master Mar 26, 2022
@ShaMan123
Copy link
Contributor Author

Excellent.
The only think I'm thinking of is this:

Added a debug flag for visual tests to recreate a golden file for the dev to compare changes (this means we need to relay of a qunitjs/qunit#1681 or simply use my branch)

I can simply add a env var instead of waiting for quint to allow other flags

@ShaMan123 ShaMan123 deleted the ci branch March 26, 2022 13:50
This was referenced Mar 26, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees

@asturur asturur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShaMan123 @asturur