Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): CLI debug and recreate options #7833

Merged
merged 10 commits into from
Mar 28, 2022
Merged

fix(ci): CLI debug and recreate options #7833

merged 10 commits into from
Mar 28, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Mar 26, 2022 •
edited
Loading

Finalizes #7825

Excellent.
The only think I'm thinking of is this:

Added a debug flag for visual tests to recreate a golden file for the dev to compare changes (this means we need to relay of a qunitjs/qunit#1681 or simply use my branch)

I can simply add a env var instead of waiting for quint to allow other flags

Originally posted by @ShaMan123 in #7825 (comment)

DONE

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.22 |    76.58 |   86.35 |   82.95 |                                               
 fabric.js |   83.22 |    76.58 |   86.35 |   82.95 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123
ShaMan123 commented Mar 26, 2022
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@ShaMan123 ShaMan123 changed the title fix(ci): CLI debug and recreate options fix(ci): CLI debug and recreate options Mar 26, 2022
@ShaMan123 ShaMan123 mentioned this pull request Mar 26, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |    76.58 |   86.35 |    82.9 |                                               
 fabric.js |   83.18 |    76.58 |   86.35 |    82.9 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |    76.58 |   86.35 |    82.9 |                                               
 fabric.js |   83.18 |    76.58 |   86.35 |    82.9 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.62 |   86.35 |   82.96 |                                               
 fabric.js |   83.23 |    76.62 |   86.35 |   82.96 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 mentioned this pull request Mar 26, 2022
Open
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |    76.58 |   86.35 |    82.9 |                                               
 fabric.js |   83.18 |    76.58 |   86.35 |    82.9 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.17 |    76.55 |   86.35 |   82.89 |                                               
 fabric.js |   83.17 |    76.55 |   86.35 |   82.89 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.62 |   86.35 |   82.96 |                                               
 fabric.js |   83.23 |    76.62 |   86.35 |   82.96 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |    76.58 |   86.35 |    82.9 |                                               
 fabric.js |   83.18 |    76.58 |   86.35 |    82.9 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.62 |   86.35 |   82.96 |                                               
 fabric.js |   83.23 |    76.62 |   86.35 |   82.96 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |    76.58 |   86.35 |    82.9 |                                               
 fabric.js |   83.18 |    76.58 |   86.35 |    82.9 | ...,29889,30014,30094-30159,30282,30381,30617 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur
Copy link
Member

asturur commented Mar 28, 2022

there was a little bug i noticed using the new ci, i think that sometimes the full suite does not start if i select it from the menu.
But overall is a great improvement.

@ShaMan123 ShaMan123 merged commit 85ad08c into master Mar 28, 2022
@ShaMan123 ShaMan123 deleted the cli-debug-option branch March 28, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur