Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(): fix typo, fix JSDOC for website, minors #7853

Merged
merged 3 commits into from
Apr 3, 2022
Merged

docs(): fix typo, fix JSDOC for website, minors #7853

merged 3 commits into from
Apr 3, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Apr 2, 2022 •
edited
Loading

  • misc: Simple typo
  • animate: JSDOC generator error fix for the website

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.13 |     76.5 |   86.24 |   82.85 |                                               
 fabric.js |   83.13 |     76.5 |   86.24 |   82.85 | ...,29966,30091,30171-30236,30359,30458,30694 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.14 |    76.54 |   86.24 |   82.86 |                                               
 fabric.js |   83.14 |    76.54 |   86.24 |   82.86 | ...,29970,30095,30175-30240,30363,30462,30698 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 mentioned this pull request Apr 2, 2022
Merged
@ShaMan123 ShaMan123 changed the title docs(misc): fix typo docs(): fix typo, fix JSDOC for website, minors Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.14 |    76.54 |   86.24 |   82.86 |                                               
 fabric.js |   83.14 |    76.54 |   86.24 |   82.86 | ...,29970,30095,30175-30240,30363,30462,30698 
-----------|---------|----------|---------|---------|-----------------------------------------------

asturur
asturur reviewed Apr 3, 2022
View reviewed changes
src/util/misc.js
@@ -1044,7 +1044,7 @@
* this is equivalent to remove from that object that transformation, so that
* added in a space with the removed transform, the object will be the same as before.
* Removing from an object a transform that scale by 2 is like scaling it by 1/2.
* Removing from an object a transfrom that rotate by 30deg is like rotating by 30deg
* Removing from an object a transform that rotate by 30deg is like rotating by 30deg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i spelled transform in all possible way, and different people corrected one part of it

@asturur asturur merged commit 1b99e62 into master Apr 3, 2022
@ShaMan123 ShaMan123 deleted the docs-typo branch April 3, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur