Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TS): migrate parser #8122

Merged
merged 23 commits into from
Aug 8, 2022
Merged

chore(TS): migrate parser #8122

merged 23 commits into from
Aug 8, 2022

Conversation

ShaMan123
Copy link
Contributor

dreadful work
forgive me

@ShaMan123 ShaMan123 requested a review from asturur August 4, 2022 17:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.14 |    74.59 |   84.47 |   80.73 |                                               
 fabric.js |   82.14 |    74.59 |   84.47 |   80.73 | ...,27505,27515-27559,27667,27754,27958,28099 
-----------|---------|----------|---------|---------|-----------------------------------------------

Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing changed
split everything to modules
moved consts from HEADER to parser

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.14 |    74.59 |   84.47 |   80.73 |                                               
 fabric.js |   82.14 |    74.59 |   84.47 |   80.73 | ...,27505,27515-27559,27667,27754,27958,28099 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123 added a commit that referenced this pull request Aug 4, 2022
@asturur
Copy link
Member

asturur commented Aug 8, 2022

Nothing changed split everything to modules moved consts from HEADER to parser

I will trust you because i can't read this thing. Tests pass, is good.

forgive me

No, because you were perfectly aware that after you put hours in something i let go because i don't want to waste people time.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.06 |     74.5 |   84.49 |   80.64 |                                               
 fabric.js |   82.06 |     74.5 |   84.49 |   80.64 | ...,27517,27527-27571,27679,27766,27970,28111 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit 82ffc25 into master Aug 8, 2022
@ShaMan123
Copy link
Contributor Author

I understand your view and respect it.
I became impatient and wanted to move forward not being stuck on objects because of the parser. I wanted to fix all imports on objects files.
So I did this. I should have left it to you.

@asturur asturur deleted the ts-parser branch September 11, 2022 23:03
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
Co-authored-by: Andrea Bogazzi <andreabogazzi79@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants