Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TS): extract caches from HEADER #8198

Merged
merged 29 commits into from Aug 30, 2022
Merged

chore(TS): extract caches from HEADER #8198

merged 29 commits into from Aug 30, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Aug 27, 2022

first merge #8194 and update from master

extracts caches to a dedicated file

we can migrate the objects to Map if we want... Has set get has clear, useful for caches

@ShaMan123 ShaMan123 requested a review from asturur August 27, 2022 05:21
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.17 |    74.68 |   84.36 |   80.73 |                                               
 fabric.js |   82.17 |    74.68 |   84.36 |   80.73 | ...-27645,27761-27762,27783-27824,27839-27998 
-----------|---------|----------|---------|---------|-----------------------------------------------

Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arcToSegmentsCache is unused across fabric...
I guess it was used before...

blame points to #6504
It was lost there. Was it intentional?
Should we cache makePathSimpler which is the only caller instead?

@ShaMan123 ShaMan123 mentioned this pull request Aug 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2022

Coverage after merging ts-cache into master will be

80.83%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
dist
   fabric.js79.08%75.05%84.70%80.83%10047, 10059, 10073, 10102, 10119–10120, 10123, 10132–10133, 10133, 10133–10134, 10136–10138, 10145, 10145, 10145–10147, 10149–10150, 10157–10159, 10186–10188, 10190–10191, 10194–10195, 10266, 10285–10287, 10289–10290, 10352, 10406, 10421, 10477, 10513–10514, 10520, 10524–10525, 10540, 10574, 10605–10606, 10630, 10638, 10725, 10757–10758, 1078, 10833–10834, 10837, 10842, 10864, 10864, 10864, 10864, 10864, 10864, 10864–10865, 10867–10868, 10868, 10868–10869, 10874, 10876, 10882, 10882, 10882, 10882, 10882–10883, 10885–10889, 10889, 10889–10891, 10893–10894, 10903, 10914, 10925, 10936, 10946–10949, 10957–10958, 10958, 10958–10959, 10961–10962, 10969, 10973, 1153, 1155–1156, 11570, 11575, 1158–1159, 11617–11619, 11619, 11619, 11619, 11619, 11619–11620, 11640, 11645–11646, 1166, 11694–11695, 1170, 11709, 11709, 11752, 11752, 11752, 11754, 1178, 11902–11903, 11914, 12071–12072, 12079, 12122, 12129, 12129, 12138–12139, 1214, 12150, 1216, 1216, 1216, 1216, 1216–1217, 12190, 12198, 12217–12219, 12246–12247, 12250, 12250, 12267–12269, 12372, 12457–12458, 12460–12461, 12468, 12492, 12557–12558, 12562, 12642, 12651, 12656, 12693, 12794, 12794, 12794, 12818–12819, 12927, 12930, 12992, 12998, 13005, 13012, 13018, 13024, 13031, 13038, 13044–13045, 13045, 13045, 13060–13061, 13069, 13078, 13078, 13103–13106, 13145, 13188–13189, 13229–13230, 13363–13364, 13509, 13601, 13664, 13667, 13720–13721, 13721, 13721, 13724, 13739, 13753, 13765–13766, 13768, 13780–13781, 13783, 13798, 13813–13814, 13816–13817, 13819–13820, 1383, 1383, 13830, 1385, 13860, 13860, 13860, 13860, 13860, 13860, 13860, 13860, 13885, 13887, 13887–13889, 13942–13944, 13967, 13975, 13981–13982, 14023, 14086–14087, 14121, 14142–14143, 14202, 14202, 14202, 14202, 14202, 14207–14215, 14257, 1435, 14383–14384, 14420, 14429, 14450, 14450, 14450–14451, 14451, 14451, 14451, 14451–14452, 14458–14460, 14463–14464, 14477, 14477, 14477–14478, 14478, 14478, 14478, 14478–14479, 14485–14487, 14490–14491, 14504–14505, 14579, 14628, 14632, 14757, 14787–14788, 14788, 14788–14789, 14789, 14789–14790, 14792, 14792, 14792–14793, 14796, 14803, 14888, 15001, 15050, 15120, 15124, 15194, 15251–15252, 15266, 15316–15317, 15319–15320, 15412, 15472, 15475, 1555, 15550, 15553, 15568–15569, 15578, 15620, 15624, 15649–15650, 15684, 15688, 15954, 15958, 16122, 16125, 16132–16133, 16133, 16133–16135, 16137, 16137, 16137–16139, 16139, 16139–16141, 1616, 16231, 16236–16238, 16266–16267, 16334, 16337, 16337, 16337–16338, 16340–16341, 16341, 16341–16342, 16342, 16342, 16344–16345, 16347, 16350, 16377, 16377–16379, 16428, 16428, 16463, 16498, 16498, 16498, 16501–16502, 16504, 16504, 16508, 16511, 16514, 16516–16517, 16526, 16531, 16531–16533, 16533, 16544–16545, 16554, 16554, 16554, 16554, 16554–16555, 16555, 16555–16557, 16557–16558, 16558, 16575–16576, 16576, 16576, 16598–16599, 16599, 16599, 16599, 16599, 16599, 16611, 16611, 16614–16618, 16618, 16657, 16696, 16728, 16731–16734, 16744, 16757, 16772, 16789, 16798, 16802, 16854, 16856–16858, 16872, 16874–16875, 16891, 16943, 16966, 17099, 17161–17163, 17163–17164, 17164, 17192, 17237–17240, 17247, 17249–17250, 17265–17267, 1727, 17277, 17277, 17277, 1728, 17340, 17352, 17352, 17399–17400, 17418–17419, 17440, 17482, 17482–17483, 17500–17503, 17503, 17503–17504, 17506, 17506, 17506–17507, 17509–17510, 17510, 17510–17511, 17513, 17513, 17513–17514, 17516–17517, 17521–17522, 17569, 176, 17613, 17682, 17687, 17710–17714, 17714, 17714–17715, 17717, 17725, 17728, 17728, 17728–17730, 17730, 17730–17732, 17732, 17732–17736, 17740–17741, 17748, 17748, 17748, 17748, 17748–17749, 17751–17752, 17768–17769, 17771–17772, 17779–17782, 17785, 17788, 17790–17791, 17791, 17791, 17791, 17791, 17791, 17791–17792, 17794, 17796–17797, 17797, 17797–17800, 17802, 17809–17817, 17817, 17817–17819, 17822, 17830–17833, 17839–17840, 17840, 17840–17841, 17843, 17843, 17843–17844, 17846, 17848–17849, 17864, 17866, 17866, 17866–17867, 17869–17870, 17870–17871, 17871, 17877, 17877, 17879, 17879–17880, 17880, 17889–17891, 17891, 17891–17899, 179, 17905, 17905, 17905–17907, 17909, 17915–17916, 17930–17936, 17936, 17936–17937, 17940, 17942, 17954, 17954, 17954–17955, 17958–17960, 17970, 17970, 17970–17972, 17984, 17984, 17984–17985, 17987–17988, 17988, 17988–17989, 17991–17992, 17992, 17992–17995, 17995, 17995–17996, 17998, 17998, 17998–17999, 180, 18002–18003,

@asturur asturur merged commit bdae9d0 into master Aug 30, 2022
@asturur asturur deleted the ts-cache branch September 11, 2022 23:03
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
Co-authored-by: Andrea Bogazzi <andreabogazzi79@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants