chore(TS): config #8194

ShaMan123 · 2022-08-26T15:52:15Z

@asturur What do you think about this approach?
If you approve I will replace all occurrences of the configured files

Extract config from HEADER to a dedicated class

github-actions · 2022-08-26T15:54:37Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.11 |    74.63 |   84.34 |   80.73 |                                               
 fabric.js |   82.11 |    74.63 |   84.34 |   80.73 | ...-27673,27789-27790,27811-27852,27867-28026 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-26T15:55:10Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.12 |    74.66 |   84.34 |   80.74 |                                               
 fabric.js |   82.12 |    74.66 |   84.34 |   80.74 | ...-27673,27789-27790,27811-27852,27867-28026 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-26T15:56:05Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.12 |    74.66 |   84.34 |   80.74 |                                               
 fabric.js |   82.12 |    74.66 |   84.34 |   80.74 | ...-27673,27789-27790,27811-27852,27867-28026 
-----------|---------|----------|---------|---------|-----------------------------------------------

src/config.ts

asturur · 2022-08-26T21:06:14Z

src/config.ts

+     */
+    forceGLPutImageData = false
+
+    NUM_FRACTION_DIGITS = 2


We should leave a note here, that this represent the number of digits when exporting to json. Is a good idea to bump this to 4 or more for designs app, and that is kept to 2 otherwise testing the library is a mess

I think we should remove this strange const and introduce it in the options object passed to toObject and toSVG
It is really bad IMO, e.g. #8178

And fix tests accordingly

bumped to 4

asturur · 2022-08-26T21:07:01Z

for me is fine, those things had to go out from header ( probably all header will go away )

ShaMan123 · 2022-08-26T23:40:17Z

header go away!

github-actions · 2022-08-26T23:46:53Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.69 |   84.44 |   80.67 |                                               
 fabric.js |   82.05 |    74.69 |   84.44 |   80.67 | ...-27584,27700-27701,27722-27763,27778-27937 
-----------|---------|----------|---------|---------|-----------------------------------------------

testem doesn't log errors for some inane reason

This reverts commit 51aef74.

github-actions · 2022-08-27T01:59:48Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.21 |    74.78 |    84.5 |   80.77 |                                               
 fabric.js |   82.21 |    74.78 |    84.5 |   80.77 | ...-27630,27746-27747,27768-27809,27824-27983 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-27T02:11:34Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.2 |    74.75 |    84.5 |   80.75 |                                               
 fabric.js |    82.2 |    74.75 |    84.5 |   80.75 | ...-27630,27746-27747,27768-27809,27824-27983 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-27T02:47:26Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.21 |    74.69 |    84.4 |   80.77 |                                               
 fabric.js |   82.21 |    74.69 |    84.4 |   80.77 | ...-27644,27760-27761,27782-27823,27838-27997 
-----------|---------|----------|---------|---------|-----------------------------------------------

rollup/plugins#463

9c324da rollup/plugins#463

github-actions · 2022-08-27T04:28:57Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.17 |    74.68 |   84.35 |   80.73 |                                               
 fabric.js |   82.17 |    74.68 |   84.35 |   80.73 | ...-27650,27766-27767,27788-27829,27844-28003 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-27T04:29:44Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.18 |    74.72 |   84.35 |   80.74 |                                               
 fabric.js |   82.18 |    74.72 |   84.35 |   80.74 | ...-27641,27757-27758,27779-27820,27835-27994 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-27T04:30:32Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.18 |    74.72 |   84.35 |   80.74 |                                               
 fabric.js |   82.18 |    74.72 |   84.35 |   80.74 | ...-27641,27757-27758,27779-27820,27835-27994 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-27T04:38:13Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.17 |    74.68 |   84.35 |   80.73 |                                               
 fabric.js |   82.17 |    74.68 |   84.35 |   80.73 | ...-27641,27757-27758,27779-27820,27835-27994 
-----------|---------|----------|---------|---------|-----------------------------------------------

This reverts commit 6c06100.

This reverts commit 146fa5e.

github-actions · 2022-08-27T05:11:56Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.23 |    74.75 |   84.35 |    80.8 |                                               
 fabric.js |   82.23 |    74.75 |   84.35 |    80.8 | ...-27642,27758-27759,27780-27821,27836-27995 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123

I really dislike NUM_FRATION_DIGITS and think it should be replaced with an option
But for now I am done

ShaMan123 · 2022-08-27T09:44:58Z

HEADER.js

- */
-fabric.minCacheSideLimit = 256;
+config.configure({
+  devicePixelRatio: fabric.window.devicePixelRatio ||


once the window context is exported we should move this logic to config.ts

ShaMan123 · 2022-08-27T09:47:54Z

src/config.ts

+     * Map of font files
+     * Map<fontFamily, pathToFile> of font files
+     */
+    fontPaths: Record</** fontFamily */ string, /** pathToFile */ string> = {}


I don't really understand for this is used for
Can it be made a local var in canvas#toSVG?
It's the only place it is used....
I thought exposing registerFonts that will add fonts to fontPaths and call register fonts on node canvas.
??

this can be made local to the svg export function yes. But for this PR we should leave it here i guess.

only used by canvas.toSVG

ShaMan123 · 2022-08-28T12:55:06Z

Most of these values can be localized I guess...

asturur · 2022-08-28T13:00:50Z

HEADER.js

+    fabric.window.webkitDevicePixelRatio ||
+    fabric.window.mozDevicePixelRatio ||


i think we can verify which browser still need those, and we can removed if is something super old.

asturur · 2022-08-28T13:01:35Z

HEADER.js

- * @default 1
- */
-fabric.browserShadowBlurConstant = 1;
+fabric.charWidthsCache = {};


i m going to take care of this later for the charWidthsCache. I want to change it to a Map.

excellent

but change it in #8198

asturur · 2022-08-28T13:06:07Z

src/config.ts

+        this.fontPaths = {
+            ...this.fontPaths,
+            ...paths
+        };


Object.assign(this.fontPaths, paths) in general seems nicer to me, but i don't care.

asturur · 2022-08-28T13:08:46Z

src/typedefs.ts

+ * @todo remove once rollup supports transforming enums... ANNOYING!
+ * https://github.com/rollup/plugins/issues/463
+ */


what is the the output so far? isn't TS that supports enum?

rollup isn't doing it right and not building an object out of the enum as TS does

ShaMan123 added 3 commits August 26, 2022 18:51

Create config.ts

7a0a0fa

Update config.ts

7e2c5ff

Update config.ts

dfc942d

asturur reviewed Aug 26, 2022

View reviewed changes

src/config.ts Outdated Show resolved Hide resolved

asturur reviewed Aug 26, 2022

View reviewed changes

Update config.ts

b6933cb

ShaMan123 added 5 commits August 27, 2022 04:14

migrate

2c5f1d9

fontPaths

f788895

verbose flag on node test

51aef74

testem doesn't log errors for some inane reason

Revert "verbose flag on node test"

aa7f78f

This reverts commit 51aef74.

fix import

684a4cd

Update HEADER.js

5e15d51

ShaMan123 mentioned this pull request Aug 27, 2022

chore(TS): extract const reNonWord from HEADER #8197

Merged

Update config.ts

c7a5b40

ShaMan123 added 5 commits August 27, 2022 07:23

fix const enum iteration

9c324da

rollup/plugins#463

fix const enum iteration

479a137

9c324da rollup/plugins#463

Update config.ts

cea2d93

migrate NUM_FRACTION_DIGITS

5287f1a

Update object.js

7ac4a54

removed isWebglSupported redundant flag

9fb08eb

ShaMan123 added 5 commits August 27, 2022 07:44

extract cache

146fa5e

Update config.ts

48d64c1

move getFontCache

6c06100

Revert "move getFontCache"

5611a87

This reverts commit 6c06100.

Revert "extract cache"

34728bd

This reverts commit 146fa5e.

ShaMan123 mentioned this pull request Aug 27, 2022

chore(TS): extract caches from HEADER #8198

Merged

ShaMan123 requested a review from asturur August 27, 2022 05:21

ShaMan123 mentioned this pull request Aug 27, 2022

chore(TS): extract initFilterBackend from HEADER #8199

Merged

ShaMan123 commented Aug 27, 2022

View reviewed changes

asturur reviewed Aug 28, 2022

View reviewed changes

asturur approved these changes Aug 28, 2022

View reviewed changes

asturur merged commit cd69a80 into master Aug 28, 2022

ShaMan123 deleted the ts-config branch September 11, 2022 23:25

frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023

chore(TS): extract config values in its own module (fabricjs#8194)

72dfff7

asturur mentioned this pull request Sep 15, 2023

Restore standard status for config.disableStyleCopyPaste #9344

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(TS): config #8194

chore(TS): config #8194

ShaMan123 commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading

asturur Aug 26, 2022

ShaMan123 Aug 26, 2022

ShaMan123 Aug 26, 2022

ShaMan123 Aug 27, 2022

asturur commented Aug 26, 2022

ShaMan123 commented Aug 26, 2022

github-actions bot commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

ShaMan123 left a comment

ShaMan123 Aug 27, 2022 •

edited

Loading

ShaMan123 Aug 27, 2022

asturur Aug 28, 2022

ShaMan123 Aug 28, 2022

ShaMan123 commented Aug 28, 2022

asturur Aug 28, 2022

asturur Aug 28, 2022

ShaMan123 Aug 28, 2022

asturur Aug 28, 2022

asturur Aug 28, 2022

ShaMan123 Aug 28, 2022

		fabric.window.webkitDevicePixelRatio \|\|
		fabric.window.mozDevicePixelRatio \|\|

chore(TS): config #8194

chore(TS): config #8194

Conversation

ShaMan123 commented Aug 26, 2022 • edited Loading

github-actions bot commented Aug 26, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 26, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 26, 2022 • edited Loading

Code Coverage Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asturur commented Aug 26, 2022

ShaMan123 commented Aug 26, 2022

github-actions bot commented Aug 26, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited Loading

Code Coverage Summary

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 Aug 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShaMan123 commented Aug 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShaMan123 commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

ShaMan123 Aug 27, 2022 •

edited

Loading