chore(TS): polish text

[ShaMan123]

Motivation

Description

Changes

• extract the measuring context to top level
• types

Gist

In Action

[ShaMan123]

Text is very messy
This PR is another step forward
extracted getMeasuringContext to top level

[ShaMan123]

Thanks to TS.
I am pretty sure this fixes an open bug
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/textBaseline

[github-actions]

Build Stats

file / KB (diff)	bundled	minified
fabric	976.453 (-1.303)	309.596 (-0.143)

[github-actions]

Coverage after merging ts-polish-text into master will be

82.74%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
HEADER.js	54%	48.15%	0%	63.64%	12, 14, 14, 14, 14, 14, 16–17, 21, 21–22, 22, 22, 24, 24, 26, 28, 30–31, 77, 77, 77
src
cache.ts	97.06%	90%	100%	100%	56
canvas.class.ts	93%	89.93%	94.12%	95.06%	1047, 1047–1048, 1051, 1071, 1071, 1106, 1139–1140, 1168–1169, 1202, 1210, 1320–1321, 1323–1324, 1344–1345, 1511, 1516, 1526, 1526, 1526–1527, 1530, 474–475, 480, 489, 638–640, 685–686, 735–736, 739, 741, 784–786, 828, 833–834, 862–863
config.ts	77.27%	66.67%	66.67%	84.62%	130, 138–140, 151–153
constants.ts	100%	100%	100%	100%
intersection.class.ts	100%	100%	100%	100%
pattern.class.ts	92.19%	85.71%	100%	96.30%	118, 124, 135, 144, 96
point.class.ts	100%	100%	100%	100%
shadow.class.ts	98.51%	96%	100%	100%	157
static_canvas.class.ts	92.15%	86.75%	96.88%	94.53%	1159–1160, 1160, 1160–1161, 1281, 1291, 1345–1346, 1349, 1384–1385, 1463, 1472, 1477, 1592, 1594, 1596, 1596, 1596, 1596, 1599, 1599, 1599–1600, 1652–1654, 1656, 1658, 1658, 1658, 1658, 1662, 1662, 1662–1664, 1735, 1735–1736, 1794, 1796–1797, 1797, 1797, 1800–1801, 1801, 1801, 306, 328–332, 348, 415–416, 418–419, 428, 432–433, 435–436, 919
src/brushes
base_brush.class.ts	100%	100%	100%	100%
circle_brush.class.ts	1.52%	0%	0%	2%	101, 103–105, 114, 114, 114, 116, 118, 120–122, 124–127, 135, 142, 144, 24, 29–30, 38–42, 46–50, 57–60, 68–72, 74, 82, 82, 82, 82, 82–83, 85, 85, 85–88, 90, 98–99
pattern_brush.class.ts	97.14%	87.50%	100%	100%	22
pencil_brush.class.ts	91.91%	85.42%	100%	93.64%	123–124, 153, 153–155, 277, 281, 286–287, 69–70, 85–86
spray_brush.class.ts	1.16%	0%	0%	1.56%	100–102, 104–105, 113, 113, 113, 113, 113–114, 116–117, 124–125, 127, 129–133, 142, 146–147, 147, 155, 155, 155–158, 160–163, 167–168, 170, 172–175, 178, 185–186, 188, 190–191, 193, 200–201, 203–204, 207, 207, 214, 214, 218, 23–24, 26–28, 28, 28–30, 34, 43, 50, 57, 64, 71, 78, 90–92
src/color
color.class.ts	91.67%	84.51%	100%	94.44%	325–326, 330–331, 334–335, 41, 45, 72–73, 73, 75, 75, 75–76, 78–79
color_map.ts	100%	100%	100%	100%
constants.ts	100%	100%	100%	100%
index.ts	100%	100%	100%	100%
util.ts	100%	100%	100%	100%
src/controls
actions.ts	100%	100%	100%	100%
changeWidth.ts	100%	100%	100%	100%
control.class.ts	93.98%	88.89%	90.91%	97.78%	235, 319, 319, 354
controls.render.ts	81.63%	78%	100%	84.78%	106, 111, 121, 121, 45, 50, 61, 61, 65–72, 81–82
default_controls.ts	86.67%	66.67%	100%	100%	125, 132
drag.ts	100%	100%	100%	100%
rotate.ts	20%	12.50%	50%	22.22%	45, 51, 51, 51–52, 55–57, 59, 59, 59, 59, 59–61, 61, 61–63, 65, 65, 65–67, 67, 67–68, 73, 73, 73–74, 76, 78, 80–81
scale.ts	93.41%	92.68%	100%	93.59%	129–130, 132–134, 148–149, 181–183, 42
scaleSkew.ts	80.56%	66.67%	100%	92.31%	14, 28, 30, 30, 30, 32, 34
skew.ts	91.03%	79.31%	100%	97.67%	130–131, 162–163, 170, 176, 178
util.ts	100%	100%	100%	100%
wrapWithFireEvent.ts	100%	100%	100%	100%
wrapWithFixedAnchor.ts	100%	100%	100%	100%
src/filters
2d_backend.class.ts	92%	83.33%	100%	93.75%	35–36
FilterBackend.ts	88.89%	83.33%	100%	90%	11–12
WebGLProbe.ts	40.54%	40%	60%	36.36%	28–30, 30, 30–31, 33–35, 43, 46–48, 48, 48–51, 53, 58
base_filter.class.ts	20.47%	20.41%	31.82%	18%	100–102, 102, 102–103, 110–112, 112, 112–113, 120–123, 123, 123–124, 130, 130, 130–133, 151, 181–186, 190–191, 191, 191–194, 194, 194, 194, 194–196, 202, 211–212, 217–221, 264–267, 276, 287–288, 288, 288–289, 291, 307–309, 309, 309, 309, 309–310, 312, 314–315, 317–318, 320–322, 330–331, 333, 337–339, 343, 343, 343, 347, 347, 347–348, 370, 370, 370–374, 402, 58–59, 81–82, 84, 84, 84–85, 85, 88, 93–95, 97, 97, 97, 97, 97, 97–98
blendcolor_filter.class.ts	6.82%	0%	25%	6.35%	101, 101, 101, 101, 101, 101, 101, 101, 101, 101, 101, 101, 103–106, 108–111, 113–116, 119–122, 124–127, 129–132, 134–137, 139–140, 140, 143–144, 144, 147–148, 148, 151, 153–156, 158–160, 175, 190–195, 60, 76, 80, 90–94, 96–99
blendimage_filter.class.ts	52.86%	70%	9.09%	59.18%	130, 138–139, 154, 170–172, 180, 182, 182, 197–198, 46, 50, 54–58, 62, 72–74
blur_filter.class.ts	2.17%	0%	0%	2.90%	100–101, 103–107, 120, 135–136,

[asturur]

i really prefer this to stay in path. It makes easier to swap paths and also the path can use those segment infos for other stuff in the future, since this is info of the path itself.

[ShaMan123]

legit
so we type it on path? or we type text with

path: Path & { info: WhatEver }

[asturur]

i typed in on path, if the build pass i ll merge this PR

[asturur]

there is some weird reason why lineHeight was there, i ll check it and report back

[ShaMan123]

I wasn't sure, saw it wasn't in the signature any longer

[asturur]

it could be it was put there to ease some commone override issue but wasn't documented.
I m trying to find out.

[ShaMan123]

We can change the signature to a destructed param, then adding/removing a key is no biggy in terms of subclassing/overriding

[asturur]

we are not doing types with T anymore.
I think is good because it helps understand when is a type and when is class, on top of that i press T and i see 99% only types in the autocomplete.

At some point we ll have to sort this out

[ShaMan123]

Correct
I am not for and not entirely against.
The only true thing I dislike are names starting with T, then it is a bit weird: TTransformEvent

[ShaMan123]

Then names like TEvent might be confusing since we might have wanted to abbreviate TransformEvent into TEvent

[asturur]

@ShaMan123 i ll try to do some little work now and come back to this PR, maybe i can fix the pathInfo myself and merge.