Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TS): polish text #8489

Merged
merged 14 commits into from
Dec 11, 2022
Merged

chore(TS): polish text #8489

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cdc9745
chore(TS): polish text
ShaMan123 Dec 4, 2022
6d84e8a
pathSegmentsInfo on Text
ShaMan123 Dec 4, 2022
b506aa4
Update path.ts
ShaMan123 Dec 4, 2022
975008e
Update text.class.ts
ShaMan123 Dec 4, 2022
66e900a
revert null
ShaMan123 Dec 4, 2022
90f99d7
Update path.ts
ShaMan123 Dec 4, 2022
1e4a33f
fix test
ShaMan123 Dec 4, 2022
8503146
Merge branch 'master' into ts-polish-text
asturur Dec 8, 2022
39c0a95
clean text fromObject
ShaMan123 Dec 11, 2022
f981844
Merge branch 'master' into ts-polish-text
asturur Dec 11, 2022
7e5933f
Merge branch 'master' into ts-polish-text
asturur Dec 11, 2022
5b4308f
restore pathSegmentsInfo
asturur Dec 11, 2022
317fc3f
restored test
asturur Dec 11, 2022
2364141
prettier
asturur Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [next]

- chore(TS): polish text [#8489](https://github.com/fabricjs/fabric.js/pull/8489)
- chore(): refactor `Object.__uid++` => `uid()` [#8482](https://github.com/fabricjs/fabric.js/pull/8482)
- chore(TS): migrate object mixins to TS [#8414](https://github.com/fabricjs/fabric.js/pull/8414)
- chore(TS): migrate filters [#8474](https://github.com/fabricjs/fabric.js/pull/8474)
Expand Down
4 changes: 2 additions & 2 deletions src/mixins/text_style.mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export abstract class TextStyleMixin<
* @param {Number} lineIndex , lineIndex is on wrapped lines.
* @return {Boolean}
*/
isEmptyStyles(lineIndex: number): boolean {
isEmptyStyles(lineIndex?: number): boolean {
if (!this.styles) {
return true;
}
Expand Down Expand Up @@ -53,7 +53,7 @@ export abstract class TextStyleMixin<
* @param {Number} lineIndex to check the style on
* @return {Boolean}
*/
styleHas(property: string, lineIndex: number): boolean {
styleHas(property: string, lineIndex?: number): boolean {
if (!this.styles || !property || property === '') {
return false;
}
Expand Down
Loading