-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IText): exitEditing
should clear contextTop
#9020
Conversation
Build Stats
|
you mean making |
Are you verified since you enabled controller on textbox that when text-selection is active, scaling down the textbox works correctly and doesn't leave behind a trail of uncleaned selection? |
You mean this? Parcel.Sandbox.-.Google.Chrome.2023-06-15.11-55-44_Trim.mp4 |
yes because we are clearing up the top layer only on the texbox area, i m not sure if that means sometimes the 2 sizes aren't in sync. I would expect it maybe as an edge case while shrinking equally from the BR quicky |
These are the paths which call clearContextTop:
I am not sure how it is handled but take notice that in the video I resized using |
Motivation
Description
Reproduce:
Expected selection to be cleared.
It doesn't
This is a regression caused IMO by making
abortCursorAnimation
effecient.We need to think about this.
I am not sure if there are more cases we want to clear selection.
The only path that I am not sure about is this:
fabric.js/src/shapes/IText/ITextKeyBehavior.ts
Lines 106 to 108 in 00bbc7c
The rest seem fine.
I am quite sure that draggable text needs blur NOT to clear selection, but that might be incorrect. Due to
_renderDragEffects
handling that.Changes
Gist
In Action