Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Canvas) mouseout target is broken for hoveredTargets #9656

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ahaensler
Copy link

@ahaensler ahaensler commented Feb 6, 2024

Description

There's a small copy/paste blunder in the _onMouseOut function.
Line 147 works:

target && target.fire('mouseout', { e: e });

Line 152 doesn't work:

 _target && target.fire('mouseout', { e: e });

I got the following error because target was null while _target wasn't. This PR fixes the error.

In Action

image

Thank you for this useful library. Looking forward to v6!

Copy link

codesandbox bot commented Feb 6, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@asturur
Copy link
Member

asturur commented Feb 8, 2024

Thank you for the PR!.
I m not sure the 5.x branch can still deploy a version to npm, i ll merge and try

@asturur asturur changed the title fix(v5) mouseout target is broken for hoveredTargets fix(Canvas) mouseout target is broken for hoveredTargets Feb 8, 2024
@asturur asturur merged commit 8318f69 into fabricjs:5.x Feb 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants