Conversation
Code on successful login: $forum = new Forum(); $forum->resetPassword(strtolower(str_replace(' ', '', $member_strforumusername)), $member_strforumhash ); $forum->login( strtolower(str_replace(' ', '', $member_strforumusername)) , $stremail, $member_strforumhash);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix the code formatting?
Please don't change any whitespace and just add your new feature.
Hi @fabwu Sorry, this is my first folk and commit to github. I will clean that up and let you know soon. |
Hi @fabwu I have grabbed original file "Forum.php" from your master branch. And put in my new functions. But the diff of the changed "Forum.php" really confused me. Sorry if that is still not right and I can update this pull request if that still needs adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries I did the same mistake on my first PR.
Unfortunately it's still not ok. Make sure you take the same file and just touch the lines which are affected from your change and leave the others as they are.
Removed the redundant spaces
Replaced tabs to spaces
Hi @fabwu Sorry about taking that long. Here is the newest version without strange new lines. |
There were a lot of API changes since the last update so this won't work with the new version. |
Code on successful login:
$forum = new Forum();
$forum->resetPassword(strtolower(str_replace(' ', '', $member_strforumusername)), $member_strforumhash );
$forum->login( strtolower(str_replace(' ', '', $member_strforumusername)) , $stremail, $member_strforumhash);