Skip to content
This repository has been archived by the owner on Oct 13, 2019. It is now read-only.

Added new functions to reset password #8

Closed
wants to merge 5 commits into from

Conversation

dkaitou
Copy link

@dkaitou dkaitou commented May 28, 2018

Code on successful login:

$forum = new Forum();
$forum->resetPassword(strtolower(str_replace(' ', '', $member_strforumusername)), $member_strforumhash );
$forum->login( strtolower(str_replace(' ', '', $member_strforumusername)) , $stremail, $member_strforumhash);

Code on successful login:

$forum = new Forum();
$forum->resetPassword(strtolower(str_replace(' ', '', $member_strforumusername)), $member_strforumhash  );
$forum->login( strtolower(str_replace(' ', '', $member_strforumusername)) , $stremail, $member_strforumhash);
Copy link
Owner

@fabwu fabwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the code formatting?

Please don't change any whitespace and just add your new feature.

@dkaitou
Copy link
Author

dkaitou commented May 30, 2018

Hi @fabwu

Sorry, this is my first folk and commit to github. I will clean that up and let you know soon.

@dkaitou dkaitou closed this May 31, 2018
@dkaitou dkaitou reopened this May 31, 2018
@dkaitou
Copy link
Author

dkaitou commented May 31, 2018

Hi @fabwu

I have grabbed original file "Forum.php" from your master branch. And put in my new functions.

But the diff of the changed "Forum.php" really confused me.

Sorry if that is still not right and I can update this pull request if that still needs adjustments.

Copy link
Owner

@fabwu fabwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries I did the same mistake on my first PR.

Unfortunately it's still not ok. Make sure you take the same file and just touch the lines which are affected from your change and leave the others as they are.

Removed the redundant spaces
Replaced tabs to spaces
@dkaitou
Copy link
Author

dkaitou commented Oct 22, 2018

Hi @fabwu

Sorry about taking that long. Here is the newest version without strange new lines.
Please let me know if there are any other problems.

@fabwu
Copy link
Owner

fabwu commented Feb 2, 2019

There were a lot of API changes since the last update so this won't work with the new version.

@fabwu fabwu closed this Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants