Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add props to page url to lookup correct page by id #53

Merged
merged 2 commits into from
Oct 7, 2019
Merged

add props to page url to lookup correct page by id #53

merged 2 commits into from
Oct 7, 2019

Conversation

reubengt
Copy link
Collaborator

@reubengt reubengt commented Oct 7, 2019

relates #50

crianonim
crianonim approved these changes Oct 7, 2019
View reviewed changes
Copy link
Collaborator

@crianonim crianonim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reubengt reubengt changed the title add props to page url to lookup correct page by id add props to page url to lookup correct page by id #50 Oct 7, 2019
@reubengt reubengt changed the title add props to page url to lookup correct page by id #50 add props to page url to lookup correct page by id Oct 7, 2019
@codecov
Copy link

codecov bot commented Oct 7, 2019 •
edited
Loading

Codecov Report

Merging #53 into master will increase coverage by 2.37%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   23.07%   25.45%   +2.37%     
==========================================
  Files           9        9              
  Lines          52       55       +3     
  Branches       10       10              
==========================================
+ Hits           12       14       +2     
- Misses         30       31       +1     
  Partials       10       10
Impacted Files Coverage Δ
src/components/MapPage/MapPage.js 100% <ø> (ø) ⬆️
src/components/App.js 50% <0%> (-50%) ⬇️
src/components/PlacePage/PlacePage.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9f949...3bc3d42. Read the comment docs.

@victormasson21 victormasson21 merged commit b2b47eb into master Oct 7, 2019
@victormasson21 victormasson21 deleted the routing-props branch October 8, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crianonim crianonim crianonim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reubengt @crianonim @victormasson21