Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for L5.5 & 5.6 #21

Merged
merged 1 commit into from Aug 31, 2019
Merged

Conversation

conroyp
Copy link
Contributor

@conroyp conroyp commented Aug 30, 2019

The docs currently list support for Laravel versions 5.5 and 5.6, but because of a dependency on callable array syntax functionality in the action function, any error triggered on a 5.5 or 5.6 app falls back to the old-style whoops screen (https://github.com/facade/ignition/issues/20).

This PR changes the action call into the ShareReportController to the uglier, older style until such a time as support for 5.5 and 5.6 is officially dropped.

There's a similar action() call in this file also relying on the callable syntax, for telescope logging. That has been left alone here - it doesn't need to change as telescope itself has a minimum version of 5.7, where this problem no longer exists.

@conroyp conroyp changed the title Add support L5.5 & 5.6 Add support for L5.5 & 5.6 Aug 30, 2019
@freekmurze freekmurze merged commit 4e57ac2 into facade:master Aug 31, 2019
@freekmurze
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants