Skip to content

Commit

Permalink
fix permission error for safe directory
Browse files Browse the repository at this point in the history
Summary:
In D48757822, we added the safe directory to the system gitconfig. However, for native runs
of workflows including Ubuntu-20 and Ubuntu-22, this does not work for permission error.
(see actions/checkout#1169)

This change fixes it by adding safe directory to global config instead.

Reviewed By: therealgymmy

Differential Revision: D48787452

fbshipit-source-id: dbe41ad42249e72d1c98e4af10ac977ba49b791d
  • Loading branch information
Jaesoo Lee authored and facebook-github-bot committed Aug 29, 2023
1 parent f23785a commit 1028d2c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-cachelib-ubuntu-20.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: "checkout sources"
uses: actions/checkout@v3
- name: "Add workspace as a safe directory"
run: git config --system --add safe.directory $GITHUB_WORKSPACE
run: git config --global --add safe.directory $GITHUB_WORKSPACE
- name: "Install Prerequisites"
run: ./contrib/build.sh -S -B
- name: "Test: update-submodules"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-cachelib-ubuntu-22.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: "checkout sources"
uses: actions/checkout@v3
- name: "Add workspace as a safe directory"
run: git config --system --add safe.directory $GITHUB_WORKSPACE
run: git config --global --add safe.directory $GITHUB_WORKSPACE
- name: "Install Prerequisites"
run: ./contrib/build.sh -S -B
- name: "Test: update-submodules"
Expand Down

0 comments on commit 1028d2c

Please sign in to comment.