feat(v2): pluginify pages #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
commented
Mar 13, 2019
|
|
||
| describe('docusaurus-plugin-content-pages', () => { | ||
| describe('loadContents', () => { | ||
| test.each([ |
There was a problem hiding this comment.
I'm trying out test.each here to reduce repetition. Lemme know if you don't like it. I don't have strong objections against going back to the former approach.
| import loadSetup from '../loadSetup'; | ||
|
|
||
| describe('loadRoutes', () => { | ||
| test('simple website', async () => { | ||
| const props = await loadSetup('simple'); | ||
| const {routesPaths} = await loadRoutes(props); |
There was a problem hiding this comment.
loadSetup() already calls loadRoutes() internally, there's no need to call it again.
|
Deploy preview for docusaurus-preview ready! Built with commit 11fa7e6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Plugin-ify the pages. The API seems to be fine, I didn't need to change it.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I updated some of the tests that broke due to the change. Let's also co-locate the tests because eventually we'll shift into packages. Also, it's easier to discover tests when they're right beside the code it's testing.
Related PRs
NA.