fix(v2): fix hot reload sometimes not working due to altered modules #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 2427265 |
|
Deploy preview for docusaurus-preview ready! Built with commit 2427265 |
yangshun
reviewed
Apr 18, 2019
| // Transform back loaded modules back into the original structure. | ||
| const loadedModules = originalModules; | ||
| // clone the original object since we don't want to alter the original. | ||
| const loadedModules = JSON.parse(JSON.stringify(modules)); |
There was a problem hiding this comment.
Interesting. I thought I was using _.cloneDeep here. If we import just the function it's fine:
import cloneDeep from 'lodash/cloneDeep`; // It's ok, just cloneDeep is imported
// vs
import _ from 'lodash`; // Not ok, the entire lodash is importedThere was a problem hiding this comment.
Sry I removed it before because bundle size is still very big. Few KBs saved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes hot reload not working because we alter the modules object.
Try to deep clone the object with json clone trick. Lodash cloneDeep would do the job but lodash cloneDeep can make our bundle size bigger :| and according to lodash/lodash#1984 (comment) it is also slower than simple JSON clone trick.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Hot reload working
Related PRs
#1366 #1367