Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Sonar to Flipper + ran prettier #905

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Conversation

patapizza
Copy link
Contributor

  • Noticed caption was "Sonar" but redirecting to https://fbflipper.com.
  • Fixed caption and renamed files for consistency.
  • Moved project after FastText to keep alphabetical ordering.
  • Ran prettier and included changes.

Test Plan

npm run test && npm run prettier && npm run lint
cd website && npm run start

Noticed projects are rendered properly and caption is now "Flipper".

screen shot 2018-08-17 at 11 40 18 am

* Noticed caption was "Sonar" but redirecting to https://fbflipper.com.
* Fixed caption and renamed files for consistency.
* Moved project after FastText to keep alphabetical ordering.
* Ran prettier and included changes.

Test plan:
  npm run test && npm run prettier && npm run lint

  cd website && npm run start

Noticed projects are rendered properly and caption is now "Flipper".
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 4f1e1a0

https://deploy-preview-905--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 17, 2018
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @patapizza! We added Sonar long ago and wasn't aware of the rename. Thanks so much!

@yangshun yangshun merged commit 0a3f0ec into facebook:master Aug 17, 2018
@patapizza
Copy link
Contributor Author

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants