Fix nav to take full width in the docs page #935
Conversation
|
Deploy preview for docusaurus-preview ready! Built with commit ef884ae |
lib/static/css/main.css
Outdated
| @@ -712,6 +712,11 @@ blockquote { | |||
| .mainContainer .wrapper .posts .post { | |||
| width: 100%; | |||
| } | |||
|
|
|||
| .docMainContainer { | |||
| flex-basis: 920px !important; | |||
There was a problem hiding this comment.
Can we avoid using !importants?
| @@ -66,7 +66,7 @@ class DocsLayout extends React.Component { | |||
| metadata={metadata}> | |||
| <div className="docMainWrapper wrapper"> | |||
| <DocsSidebar metadata={metadata} /> | |||
| <Container className="mainContainer"> | |||
| <Container className="mainContainer docMainContainer"> | |||
There was a problem hiding this comment.
Why not directly add the rules within docMainContainer into mainContainer? Is there a need for a new class?
There was a problem hiding this comment.
because the class is used in other page, like blog so it may break the other page if i modify it directly
| @@ -116,7 +116,7 @@ class DocsLayout extends React.Component { | |||
| )} | |||
| </Container> | |||
| {hasOnPageNav && ( | |||
| <nav className="onPageNav"> | |||
| <nav className="onPageNav docOnPageNav"> | |||
There was a problem hiding this comment.
Same question regarding this line.
There was a problem hiding this comment.
because the class is used in other page, like blog so it may break the other page if i modify it directly
|
There's a difference in the new layout and the current one - The "Getting Started" is no longer flushed with the Docusaurus icon in the navbar. Old
New
|
|
@yangshun adjusted based on your review! 😃 please review! |
|
Great work @fiennyangeln! |
|
Thank you @fiennyangeln 😄 |
|
Thanks for the review @yangshun |
|
Thanks for fixing it! 🎉 |
|
Great work @fiennyangeln 🎉 Proud as a senior 😭 |
Fix #911
Motivation
Fix the Nav in the docs page to take the full width so that when scrolled it does not scroll the main container
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)
No