Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navs next to content take up full width #911

Closed
SimenB opened this issue Aug 22, 2018 · 10 comments
Closed

Make navs next to content take up full width #911

SimenB opened this issue Aug 22, 2018 · 10 comments
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. status: claimed Issue has been claimed by a contributor who plans to work on it.

Comments

@SimenB
Copy link
Contributor

SimenB commented Aug 22, 2018

馃殌 Feature

Make the left and right hand navs take up the outer width to facilitate easier scrolling

Motivation

When scrolling, you have to have the mouse above the ToC to scroll it instead of the page's content. On the right hand, it's easy to have the cursor too far to the right, scrolling the document instead of the content

Pitch

I'm unable to take a screenshot of the pointer, but it's easy to move it too far to the right if the word in the ToC is long enough, e.g.:
image

If the pointer is a smidge to the right of "modulePathIgnorePatterns [array]" then I scroll the page's content

@endiliey
Copy link
Contributor

To sum it up, for example
https://jestjs.io/docs/en/configuration#modulefileextensions-array-string

screenshot from 2018-08-22 21-48-41

Expected behavior when scrolling at point
(1) -> scroll page content
(2) and (3) -> scroll sidebar
(4) and (5) -> scroll TOC

Current behavior when scrolling at point
(1) and (2) and (5) -> scroll page content
(3) -> scroll sidebar
(4) -> scroll TOC

Is this correct @SimenB ?

@endiliey endiliey added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. mentorship labels Aug 22, 2018
@SimenB
Copy link
Contributor Author

SimenB commented Aug 22, 2018

Yup, perfect!

@SimenB
Copy link
Contributor Author

SimenB commented Aug 22, 2018

The left part is fine, but because of the alignment of the right one it's easy to have the cursor too far to the right

@fiennyangeln
Copy link
Contributor

Hi I would like to work on this

@JoelMarcey JoelMarcey added the status: claimed Issue has been claimed by a contributor who plans to work on it. label Aug 22, 2018
@yangshun
Copy link
Contributor

yangshun commented Aug 22, 2018

@fiennyangeln it's yours!

I've added an "issue: claimed" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

I'll check in with you periodically so that we can keep the task updated with the progress.

@JoelMarcey
Copy link
Contributor

@fiennyangeln Excellent! Thank you so much.

We've added an issue: claimed label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Of course, I'll check in with you so that we can keep the task updated with the progress. 馃槃

@JoelMarcey
Copy link
Contributor

Ha ha ha @yangshun and I were thinking the same thing 馃ぃ

@SimenB
Copy link
Contributor Author

SimenB commented Aug 22, 2018

Another thing I noticed that's semi related is that while the left hand navigation gets a scrollbar, the right one does not. Intentional?

@fiennyangeln
Copy link
Contributor

fiennyangeln commented Aug 25, 2018

Hmm, do you think its ok if i add another CSS Class to modify the change since i realize most of the css class used by the page like docsNavContainer and mainContainer are used by other page and my change (set flex:1 to the docsNavContainer and onPageNav, remove max-width:1400px and margin:0 auto in the docMainWrapper) will affect other page like Blog ? @JoelMarcey @yangshun

@JoelMarcey
Copy link
Contributor

Hi @fiennyangeln Would adding anything to our custom.css file help you here? https://github.com/facebook/Docusaurus/blob/master/website/static/css/custom.css

fiennyangeln pushed a commit to fiennyangeln/Docusaurus that referenced this issue Sep 1, 2018
yangshun pushed a commit that referenced this issue Sep 9, 2018
* Fix nav to take full width in the docs page

Fix #911

* Remove using important in css

* Make Getting started flushed together with icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. status: claimed Issue has been claimed by a contributor who plans to work on it.
Projects
None yet
Development

No branches or pull requests

5 participants