Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-selects python2 if available in the environment #15

Merged
merged 1 commit into from
May 7, 2015

Conversation

lsmag
Copy link

@lsmag lsmag commented May 7, 2015

Simple patch I made to work on systems where python2 is available. Closes issues #12

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@pcottle
Copy link
Contributor

pcottle commented May 7, 2015

awesome! however im still getting an error output when running this locally -- think you need to merge error stdout to devnull as well

[pcottle:~/Dropbox (Facebook)/wip/PathPicker:]$ ./fpp 
./fpp: line 27: type: python2: not found

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@pcottle
Copy link
Contributor

pcottle commented May 7, 2015

Think it works best as:

[pcottle:~/Dropbox (Facebook)/wip/PathPicker:]$ if type asd &> /dev/null; then echo "git exists"; fi
[pcottle:~/Dropbox (Facebook)/wip/PathPicker:]$ if type git &> /dev/null; then echo "git exists"; fi
git exists

pcottle added a commit that referenced this pull request May 7, 2015
Auto-selects python2 if available in the environment
@pcottle pcottle merged commit 99ef5d4 into facebook:master May 7, 2015
pcottle added a commit that referenced this pull request May 7, 2015
pcottle added a commit that referenced this pull request May 7, 2015
@pcottle
Copy link
Contributor

pcottle commented May 7, 2015

Alright all good, thanks for adding linux support while maintaining our mac support!

@pcottle pcottle mentioned this pull request May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants