Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to api.openstreetmap.org host #1130

Closed
bhousel opened this issue Sep 28, 2023 · 2 comments
Closed

Switch to api.openstreetmap.org host #1130

bhousel opened this issue Sep 28, 2023 · 2 comments
Labels
chore Improvements to the code or development stack, cleanups
Milestone
v2.2.0

Comments

@bhousel
Copy link
Contributor

bhousel commented Sep 28, 2023

Looks like OSM would prefer if we use api.openstreetmap.org instead of www.openstreetmap.org
see openstreetmap/operations#951
@bhousel bhousel added the chore Improvements to the code or development stack, cleanups label Sep 28, 2023
bhousel added a commit that referenced this issue Oct 23, 2023
@bhousel
Revert 4e6b7aa
4cc756d 
(re: #1130)

Apparently the `api.openstreetmap.org` won't work with OAuth2 yet.
It currently tries to redirect to `www.openstreetmap.org` which triggers a
CORS issue (the 2 domains are considered different origins)

Will hold off on this for now and watch openstreetmap/operations#951
@bhousel bhousel reopened this Oct 23, 2023
@bhousel
Copy link
Contributor Author

bhousel commented Oct 23, 2023

Apparently the api.openstreetmap.org won't work with OAuth2 yet.
It currently tries to redirect to www.openstreetmap.org which triggers a CORS issue (the 2 domains are considered different origins)

Will hold off on this for now and watch openstreetmap/operations#951
Also related is osmlab/osm-auth#123

@bhousel bhousel added waitfor Can't work on this until something else unblocks it and removed waitfor Can't work on this until something else unblocks it labels Oct 23, 2023
bhousel added a commit to osmlab/osm-auth that referenced this issue Oct 24, 2023
@bhousel
Support separate urls for OAuth handshake and OSM API usage
b42ca40 
(closes #123)

see also:
openstreetmap/operations#951
facebook/Rapid#1130
openstreetmap/iD@c4d1390
@bhousel
Copy link
Contributor Author

bhousel commented Oct 24, 2023

I ended up just publishing a v2.3.0 of the osm-auth package that allows for separate urls:
apiUrl - A base url for the OSM API (default: "https://api.openstreetmap.org")
url - A base url for the OAuth2 handshake (default: "https://www.openstreetmap.org")

@Bonkles Bonkles added this to the v2.2 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Improvements to the code or development stack, cleanups
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
2 participants
@bhousel @Bonkles