Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Zoom After Drawing A Feature #555

Closed
flow-enol opened this issue Aug 19, 2022 · 2 comments
Closed

Auto-Zoom After Drawing A Feature #555

flow-enol opened this issue Aug 19, 2022 · 2 comments
Milestone

Comments

@flow-enol
Copy link

Description

The auto-zoom feature after completing an edit with the "Line" or "Area" tool is glitchy (it stutters) and annoying in general.

Version

2.0-alpha

What browser are you seeing the problem on? What version are you running?

Opera GX [LVL4 {core: 89.0.4447.98) (x86_64)}

Steps to reproduce

Select the Line or Area tool - draw something and double-click when finished

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid-v2-alpha#background=Bing&datasets=fbRoads,msBuildings&map=20.45/34.00637/-117.92447

@flow-enol
Copy link
Author

The auto-zoom feature doesn't seem to have an upper limit. If you create features (with a map tool) consecutively without adjusting the zoom, it keeps zooming at increments of one zoom level until it reaches the max zoom of 24.

@Bonkles Bonkles added this to the v2 Beta milestone Aug 19, 2022
Bonkles added a commit that referenced this issue Sep 1, 2022
…essary draw behavior double-click handling code, as this was covered in the draw mode code.
@Bonkles
Copy link
Contributor

Bonkles commented Sep 1, 2022

This was caused by our not-terribly-awesome event bridging between d3-land and pixi's own event handling.

I told the d3 zoom handler to stop listening to any double click events during draw gestures- should be fixed in alpha v2.01.

Fixed in commit 4d1246040.

@Bonkles Bonkles closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

No branches or pull requests

2 participants